450297 - show pattern when browser canvas has been scrolled away

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: checkerboard canvas

Comment 1

[Stuart Parmenter]

can you layout guys take a look at this test and see if you have any idea why it is so slow?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What test did you have in mind?

Comment 3

[Stuart Parmenter]

hrm, wrong bug:/

Comment 4

[Stuart Parmenter]

brad: can you post your patch that does this using backgroundPosition on the stack as well?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: moves a background image around on that stack

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 333444 [details] [diff] [review]
checkerboard canvas

Since the background image fixes aren't coming any time soon, let's get this in now and we can swap out for the other version later

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Given Jeff's comment in bug 450400, do we want to go with the background image patch now?

Comment 8

[Stuart Parmenter]

Comment on attachment 333444 [details] [diff] [review]
checkerboard canvas

lets use the other patch instead

Comment 9

[Stuart Parmenter]

Comment on attachment 335654 [details] [diff] [review]
moves a background image around on that stack

drive-by comments:

-        <xul:stack anonid="cstack" flex="1" style="overflow: hidden;">
+        <xul:stack anonid="cstack" flex="1" style="overflow: hidden; background-image:url('chrome://browser/content/checkerboard.png')">


the background-image should be in some css file

Maybe make updateCanvasPosition() call updateCheckerboard() directly to avoid having to keep them in sync?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 335654 [details] [diff] [review]
moves a background image around on that stack

r=me with stuart's comments fixed, and tested to make sure it doesn't kill perf.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: updated for comments and bit rot

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: uses browser.css to set background image

Comment 13

[Stuart Parmenter]

Comment on attachment 342023 [details] [diff] [review]
uses browser.css to set background image

gavin: this looks right to me, but which browser.css should the background go in to?  the skin one or the content one?

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 342023 [details] [diff] [review]
uses browser.css to set background image

>diff --git a/chrome/content/browser.css b/chrome/content/browser.css

>+div[anonid="viewport"] {
>+   background-image:url('chrome://browser/content/checkerboard.png')	

Actually this belongs in deckbrowser.css, which I just realized no longer exists even though we still reference it. Just leave it in deckbrowser.xml for now (like the previous patch).

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 342022 [details] [diff] [review]
updated for comments and bit rot

carrying gavin's r+ backwards

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: checkerboard pattern

madhava, just wanted to run this by you before committing it

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

changeset:   227:21f625bd9726
tag:         tip
user:        Brad Lassey <[e-mail]>
date:        Tue Oct 07 12:28:45 2008 -0400
summary:     Bug 450297 -  show pattern when browser canvas has been scrolled away r=gavin

Comment 18

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with beta3