450348 - Make "clone this bug" optionally keep same product, and avoid product chooser

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Spun off of bug 355285, wherein several of us wanted to clone to, you know, clone a bug, rather than dropping you back to the product chooser every time you wanted to clone a bug.  Bugzilla devs indicate that requiring you to choose a product every time you want to clone a bug is the intended behavior.

---

From bug 355285 comment 0:

my definition of clone includes retaining the classification, product,
component, and assignee/qa.

the reason i make a clone is so that i don't have to search for the
product/component/assignee/qa. if i wanted to file a new bug i'd have gone off
and filed a new bug.

the cloning we use involves changing basically a flag which basically indicates
a different branch.

steps:
1. file a bug in foopy/newpie/boopy against: assi:yippie qa:darpy with summary
peppy and comment hipp-hipp-horrip
2. click clone

expected results:
bug is prefilled with foopy/newpie/boopy against: assi:yippie qa:darpy with
summary peppy and comment hipp-hipp-horrip

actual results (in a heavily customized bugzilla):
product chooser!

---

From bug 355285 comment 9:

Yes, I would expect clone to keep the component etc. That's the hardest part to
fill out.  My use case was that I needed to file a new bug for a similar task
and wasn't sure how to fill it out.  I found an old one that was correct and
hit clone.  *If* someone wants to file in a different component I think it's
just as trivial to *change* component as it is to pick one from scratch.

---

There are other comments in bug 355285 from users of other Bugzillas indicating other reasons why having clone clone without requiring a trip to the product chooser is desirable, but I've just copied these two from regular bmo users.

The good people at Eclipse have attached a patch to bug 355285 (attachment 322247 [details] [diff] [review]) that makes clone behave sanely; since there is a patch there, filing this bug against bmo to see about taking a local customization to fix cloning.

Comment 1

[Dave Miller [:justdave]]

Most of the reasons cited for having to go through the product chooser again have to do with not being able to change the product from the enter_bug form once you get to it again.  With the help of a little AJAX that's now possible on tip (3.3.x) bugzilla (but I don't know about 3.2, which we're upgrading to in the next couple weeks).  Probably worth looking into.

Comment 2

[Gervase Markham [:gerv]]

Any chance we could fix this now? I don't use clone, but I completely agree that the standard use case on b.m.o. involves creating another bug in the same product, and putting people through the product chooser (without even giving them a hint about what the product of the old bug was!) is silly.

Gerv

Comment 3

[:glob ✱]

Attachment: patch v1

this was annoying me, so here's a fix :)

this adds a javascript menu to the clone-bug link with two options:
  Clone to the current product
  Clone to a different product

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 573508 [details] [diff] [review]
patch v1

Review of attachment 573508 [details] [diff] [review]:
-----------------------------------------------------------------

I really like this and I love to see us adding fixes to things that annoy us. It works fine but a few minor changes.

::: extensions/BMO/web/js/edit_bug.js
@@ +55,4 @@
>    }
>  }
>  
> +var clone_bug_menu;

Don't need this. See below.

@@ +56,5 @@
>  }
>  
> +var clone_bug_menu;
> +
> +function init_clone_bug_menu(el, id, product, component) {

Nit: rename id to bug_id to avoid confusion, looks like it could be an element id.

@@ +64,5 @@
> +    '&component=' + encodeURIComponent(component);
> +  clone_bug_menu = new YAHOO.widget.Menu('clone_bug_menu', { position : 'dynamic' });
> +  clone_bug_menu.addItems([
> +    { text: 'Clone to the current product', url: cur_url },
> +    { text: 'Clone to a different product', url: diff_url }

Open in a new tab:
 
{ text: 'Clone to the current product', url: cur_url, target: '_blank' },
{ text: 'Clone to a different product', url: diff_url, target: '_blank' }

@@ +67,5 @@
> +    { text: 'Clone to the current product', url: cur_url },
> +    { text: 'Clone to a different product', url: diff_url }
> +  ]);
> +  clone_bug_menu.render(document.body);
> +  YAHOO.util.Event.addListener(el, 'click', show_clone_bug_menu);

Pass in clone_bug_menu as an extra param to addListener:

YAHOO.util.Event.addListener(el, 'click', show_clone_bug_menu, clone_bug_menu);

@@ +70,5 @@
> +  clone_bug_menu.render(document.body);
> +  YAHOO.util.Event.addListener(el, 'click', show_clone_bug_menu);
> +}
> +
> +function show_clone_bug_menu(event) {

function show_clone_bug_menu(event, clone_bug_menu) {

Comment 5

[:glob ✱]

Attachment: patch v2

(In reply to David Lawrence [:dkl] from comment #4)
> > +var clone_bug_menu;
> Don't need this. See below.

very nice :)

> > +  clone_bug_menu.addItems([
> > +    { text: 'Clone to the current product', url: cur_url },
> > +    { text: 'Clone to a different product', url: diff_url }
> 
> Open in a new tab:

the current link doesn't open in a new tab, which i feel is the correct behavour, so i haven't done this.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 573758 [details] [diff] [review]
patch v2

Review of attachment 573758 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl

Comment 7

[:glob ✱]

thanks dkl :)

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/BMO/web/js/edit_bug.js
modified template/en/default/bug/navigate.html.tmpl
Committed revision 7942.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/web/js/edit_bug.js
modified template/en/default/bug/navigate.html.tmpl
Committed revision 7946.