450356 - Not able to add selected add-ons to facebook page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Facebook Application, defect)

Description

[SthrnDixieCwgrl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: 

I went to my Facebook profile and clicked on the Rock your Firefox application.  Then I went under Import Add-ons and clicked on Find out more.  Then I clicked on Detect My Add-ons.  Then I followed the instructions on the screen.  Then I clicked continue.  Then I clicked on Add Selected to Favorites.  Then I got the following error message:

There are errors in this form. Please correct them and resubmit.


Reproducible: Always

Steps to Reproduce:
1. Logged into Facebook
2. Clicked on the Rock your Firefox application
3. Clicked on Find out more under Import Add-ons
4. Clicked on Detect My Add-ons
5. Followed the instructions on the screen
6. Then I clicked continue
7. Clicked on Add Selected to Favorites
Actual Results:  
Received following error message:

There are errors in this form. Please correct them and resubmit.

Expected Results:  
Add the detected Add-ons to My Favorite Add-ons section of my profile

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirmed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1; I'll attach a log showing:

* update ping (add-on scan)
* successful ping
* failed submit

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Logfile (HTML)

Could this be some CSRF change fallout?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Oh; looks like it's failing to find https://addons.mozilla.org/en-US/firefox/js/__utm.js (404).  Isn't that just the Urchin tracker, though?

Comment 4

[Justin Scott [:fligtar]]

Attachment: patch

This was caused by the CSRF check. We haven't updated RYF specifically to avoid these issues, but this part of the app runs on regular AMO so it was affected. This patch just adds the action to the CSRF exception list.

Fred, if you want to test the actual patch, you'll need to pull a session id from facebook_sessions in your db and insert it into:
http://your-amoinstall/en-US/firefox/facebookinstall/import/{sessionid}/results

Before the patch, if you submit that page's form, you'll get an error. After, you should be redirected to facebook.

Comment 5

[SthrnDixieCwgrl]

I clicked on http://your-amoinstall/en-US/firefox/facebookinstall/import/{sessionid}/results

Address Not Found

      

      
      
      

      
        
        

          

Firefox can't find the server at www.your-amoinstall.com.

        


        
        

The browser could not find the host server for the provided address.

    * Did you make a mistake when typing the domain? (e.g. "ww.mozilla.org" instead of "www.mozilla.org")
    * Are you certain this domain address exists?  Its registration may have expired.
    * Are you unable to browse other sites?  Check your network connection and DNS server settings.
    * Is your computer or network protected by a firewall or proxy?  Incorrect settings can interfere with Web browsing.

How do I fix this

(In reply to comment #4)
> Created an attachment (id=333982) [details]
> patch
> 
> This was caused by the CSRF check. We haven't updated RYF specifically to avoid
> these issues, but this part of the app runs on regular AMO so it was affected.
> This patch just adds the action to the CSRF exception list.
> 
> Fred, if you want to test the actual patch, you'll need to pull a session id
> from facebook_sessions in your db and insert it into:
> http://your-amoinstall/en-US/firefox/facebookinstall/import/{sessionid}/results
> 
> Before the patch, if you submit that page's form, you'll get an error. After,
> you should be redirected to facebook.
> 

Comment 6

[Fred Wenzel [:wenzel]]

Comment on attachment 333982 [details] [diff] [review]
patch

I checked out the patch and it works as described. If you don't select any add-ons from the list though (or all are your favorites already), you get a bunch of warnings due to the empty list. You may want to fix that, but it's a different bug.

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> I clicked on
> http://your-amoinstall/en-US/firefox/facebookinstall/import/{sessionid}/results
> 
> Address Not Found

The instructions were for me to check out Justin's patch only. If you have additional questions about addons.mozilla.org, please feel free to email [e-mail] or file a new bug here in bugzilla.

Comment 8

[Justin Scott [:fligtar]]

Checked into r17697. Thanks!

Comment 9

[Fred Wenzel [:wenzel]]

Wait a minute, I don't know if the facebook part was pushed public yet. Fligtar: If it was published, can you please remove the push-needed keyword? Thanks!

Comment 10

[Justin Scott [:fligtar]]

This part of the app is hosted on normal AMO, so it was pushed.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://addons.mozilla.org/en-US/firefox/facebookinstall/import/6b289e40b5cff7409a81592cb3d92b65986288/results# returned me to http://apps.new.facebook.com/add-ons/favorites/?added=201%2C3829.

Comment 12

[SthrnDixieCwgrl]

I went to Facebook and I tried this add-on again.  It worked. Thank you.

(In reply to comment #11)
> Verified FIXED;
> https://addons.mozilla.org/en-US/firefox/facebookinstall/import/6b289e40b5cff7409a81592cb3d92b65986288/results#
> returned me to
> http://apps.new.facebook.com/add-ons/favorites/?added=201%2C3829.
>