All files under media/ should have appropriate license headers

RESOLVED WORKSFORME

Status

()

defect
--
major
RESOLVED WORKSFORME
11 years ago
11 years ago

People

(Reporter: reed, Unassigned)

Tracking

({fixed1.9.1})

Trunk
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Seems some files under media/ are missing license headers... at least liboggplay_audio/sydney_audio.h is missing its license headers, but there may be more. Please check to make sure all files have appropriate license headers.
Flags: blocking1.9.1?
Currently, we are adopting the view that missing license headers means "same license as the code around it" - this is true of thousands of files of Mozilla code. I don't think it's worth creating divergences from upstream in 3rd party code just to add licensing headers. 

If you want to push the headers upstream and then repull, that would be great. :-) But it's not required. So I suggest WONTFIX.
 
Gerv
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
The code under liboggplay_audio/ seems to be tri-licensed, so it's not part of a third-party repo or code (we _are_ upstream), etc., so we should fix it.

Chris, correct me if I'm wrong, but I believe that you said this is not third-party code.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Whether it's third-party code or not, we don't _have_ to fix it. As long as some of the files have headers, and none have incorrect headers, I'm happy.

However, if it's Mozilla code, then I have no objection to it being fixed if someone wants to take the time to fix it.

Gerv

Comment 4

11 years ago
liboggplay_audio was the audio portion of Annodex's Firefox plugin project. Some of the code was contributed by me (the Alsa backend). They have recently (in the last week or so) split this audio code into a separate library called libsydneyaudio and I'll be updating things to reflect that.
libsydneyaudio/include/sydney_audio.h now has a header, so I think we're good for now...
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → WORKSFORME
Flags: blocking1.9.1? → blocking1.9.1+
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.