450413 - Mark messages as read UI box ungreyed after reopen settings

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Nikolay Shopik]

Go to tools->options>advanced-> uncheck "automatically mark message as read" seconds box will get disabled and greyed. Press OK to close settings, reopen settings you will see seconds box is not grey anymore. Seems trivial for me to fix.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080813031200 Shredder/3.0b1pre

Comment 1

[Magnus Melin [:mkmelin]]

I see it on linux too, one have to have "After displaying for __ seconds" selected too. 

Not sure what to do about it though. The textbox *is* disabled, it just doesn't look like it. Might be some core xul bug. 

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

UL bug or not, we're asking for it: in this state, in init, we set the radiogroup disabled, set the textbox disabled, set the seconds disabled, then go back and set the textbox enabled because that's which radiobutton is selected, ignoring the way the radiogroup is disabled. Since the rest of the time when we call updateMarkAsReadTextbox we know the radiogroup is enabled, we should leave that as is, and just get it right in updateMarkAsReadOptions, and only call that from init.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 345062 [details] [diff] [review]
Fix v.1

Looks good to me, thx! r=mkmelin

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/ad2956c65a25

Comment 5

[Nikolay Shopik]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081031 Shredder/3.0b1pre
VERIFED