Mark messages as read UI box ungreyed after reopen settings

VERIFIED FIXED in Thunderbird 3.0b1

Status

--
trivial
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: shopik, Assigned: philor)

Tracking

Trunk
Thunderbird 3.0b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Go to tools->options>advanced-> uncheck "automatically mark message as read" seconds box will get disabled and greyed. Press OK to close settings, reopen settings you will see seconds box is not grey anymore. Seems trivial for me to fix.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080813031200 Shredder/3.0b1pre
I see it on linux too, one have to have "After displaying for __ seconds" selected too. 

Not sure what to do about it though. The textbox *is* disabled, it just doesn't look like it. Might be some core xul bug. 
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 2

10 years ago
Created attachment 345062 [details] [diff] [review]
Fix v.1

XUL bug or not, we're asking for it: in this state, in init, we set the radiogroup disabled, set the textbox disabled, set the seconds disabled, then go back and set the textbox enabled because that's which radiobutton is selected, ignoring the way the radiogroup is disabled. Since the rest of the time when we call updateMarkAsReadTextbox we know the radiogroup is enabled, we should leave that as is, and just get it right in updateMarkAsReadOptions, and only call that from init.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #345062 - Flags: review?(mkmelin+mozilla)

Updated

10 years ago
Attachment #345062 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 345062 [details] [diff] [review]
Fix v.1

Looks good to me, thx! r=mkmelin
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/comm-central/rev/ad2956c65a25
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
(Reporter)

Comment 5

10 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081031 Shredder/3.0b1pre
VERIFED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.