Make the front page object invalidation capable

RESOLVED FIXED in 4.0.1

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: baz, Assigned: wenzel)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Need to modify the AMO front page to use the object invalidation framework.
(Reporter)

Updated

10 years ago
Target Milestone: --- → 4.0.1
This will cover utilizing the improved cache policy from bug 425315.
Assignee: morgamic → fwenzel
(Assignee)

Comment 2

10 years ago
Created attachment 338263 [details] [diff] [review]
Object-caching capable front page

This is the "full version" of attachment 337237 [details] [diff] [review]. The whole front page uses per-addon caching along with association-based add-on fetching, so we only haul around the data that's needed and can expire the cache on a per-addon basis.

Note that the add-on model's afterSave() callback is currently the only place where the cache expiration is triggered. That's probably not the only place where this needs to happen though -- in the versions model as well, maybe?
Attachment #338263 - Flags: review?(clouserw)
Comment on attachment 338263 [details] [diff] [review]
Object-caching capable front page

It doesn't have syntax errors. :)  I didn't test all the aspects of it so we could land sooner and get more feedback time from everyone.
Attachment #338263 - Flags: review?(clouserw) → review+
(Assignee)

Comment 4

10 years ago
Checked in to r18252. I'll file another bug so we actually invalidate the add-on objects wherever necessary.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Blocks: 455385
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
> I'll file another bug so we actually invalidate the
> add-on objects wherever necessary.

Filed: bug 455385.

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.