450464 - Redudant View throws an exception and doesn't run

Status: RESOLVED FIXED

(Mozilla Localizations Graveyard :: MozillaTranslator, defect)

Description

[RickieES aka Ricardo Palomares]

Attachment: Patch to fix exception and enhance Redundant Strings speed

Michael Wolf warned me about an exception when trying to use Redundant Strings QA check:

Exception in thread "Thread-3" java.util.MissingResourceException: Can't find re
source for bundle java.util.PropertyResourceBundle, key button.copy_to_all.label

        at java.util.ResourceBundle.getObject(Unknown Source)
        at java.util.ResourceBundle.getString(Unknown Source)
        at org.mozillatranslator.kernel.L10nManager.translate(L10nManager.java:6
0)
        at org.mozillatranslator.kernel.Kernel.translate(Kernel.java:139)
        at org.mozillatranslator.action.CopyToAllInRedundantView.<init>(CopyToAl
lInRedundantView.java:42)
        at org.mozillatranslator.gui.RedundantViewToolbar.getToolbar(RedundantVi
ewToolbar.java:49)
        at org.mozillatranslator.gui.ComplexTableWindow.<init>(ComplexTableWindo
w.java:100)
        at org.mozillatranslator.runner.ViewRedundantRunner.run(ViewRedundantRun
ner.java:103) 

It all turned out to be a misnamed resource in userinterface.properties.

However, while debugging the code I saw that the process to build the redundant strings list was too expensive, so I'm providing a patch that both solves the exception and enhances the list build speed.

The patch includes a lot of documentation and "properly written code" minor fixes.

Comment 1

[RickieES aka Ricardo Palomares]

Patch has been committed to CVS @ sf.net and will be released as part of MT v5.24.

Comment 2

[RickieES aka Ricardo Palomares]

MT v5.24 has already been released.