Redudant View throws an exception and doesn't run

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: rpmdisguise-nave, Assigned: rpmdisguise-nave)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 333601 [details]
Patch to fix exception and enhance Redundant Strings speed

Michael Wolf warned me about an exception when trying to use Redundant Strings QA check:

Exception in thread "Thread-3" java.util.MissingResourceException: Can't find re
source for bundle java.util.PropertyResourceBundle, key button.copy_to_all.label

        at java.util.ResourceBundle.getObject(Unknown Source)
        at java.util.ResourceBundle.getString(Unknown Source)
        at org.mozillatranslator.kernel.L10nManager.translate(L10nManager.java:6
0)
        at org.mozillatranslator.kernel.Kernel.translate(Kernel.java:139)
        at org.mozillatranslator.action.CopyToAllInRedundantView.<init>(CopyToAl
lInRedundantView.java:42)
        at org.mozillatranslator.gui.RedundantViewToolbar.getToolbar(RedundantVi
ewToolbar.java:49)
        at org.mozillatranslator.gui.ComplexTableWindow.<init>(ComplexTableWindo
w.java:100)
        at org.mozillatranslator.runner.ViewRedundantRunner.run(ViewRedundantRun
ner.java:103) 

It all turned out to be a misnamed resource in userinterface.properties.

However, while debugging the code I saw that the process to build the redundant strings list was too expensive, so I'm providing a patch that both solves the exception and enhances the list build speed.

The patch includes a lot of documentation and "properly written code" minor fixes.
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

10 years ago
Patch has been committed to CVS @ sf.net and will be released as part of MT v5.24.
(Assignee)

Comment 2

10 years ago
MT v5.24 has already been released.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Mozilla Localizations → Mozilla Localizations Graveyard
You need to log in before you can comment on or make changes to this bug.