Closed Bug 450613 Opened 12 years ago Closed 12 years ago
Bookmarks and Internet Search don't null-check profile change notifications
The profile-before-change notification should always have string data of shutdown-persist or shutdown-cleanse however these two services don't null-check their notifications so if someone forgets and passes a null pointer then they will crash. Note that at least for Internet Search this is only a problem with the external string API as the internal string API does do a null check.
I liked the Internet Search comparison code so I reused it for Bookmarks.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #333778 - Flags: review?(iann_bugzilla)
Comment on attachment 333778 [details] [diff] [review] Proposed patch r=me looks sensible
Attachment #333778 - Flags: review?(iann_bugzilla) → review+
Pushed changeset eb29e761c864 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.