Closed
Bug 450613
Opened 16 years ago
Closed 16 years ago
Bookmarks and Internet Search don't null-check profile change notifications
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: neil, Assigned: neil)
Details
(Keywords: crash)
Attachments
(1 file)
|
1.65 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
The profile-before-change notification should always have string data of shutdown-persist or shutdown-cleanse however these two services don't null-check their notifications so if someone forgets and passes a null pointer then they will crash. Note that at least for Internet Search this is only a problem with the external string API as the internal string API does do a null check.
|
Assignee | |
Comment 1•16 years ago
|
||
I liked the Internet Search comparison code so I reused it for Bookmarks.
|
||
Updated•16 years ago
|
Version: unspecified → Trunk
Comment on attachment 333778 [details] [diff] [review]
Proposed patch
r=me looks sensible
Attachment #333778 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed changeset eb29e761c864 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•