450614 - Engine exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [mozIStorageConnection.createStatement]"

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[live2code]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 0.2.6

Happens every time when new input object has to be created on sync with weave.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
The log file shows:
2008-08-14 12:03:22   Service.InputStore   TRACE   Processing command: {"action":"create","GUID":"http://news.google.com/","depth":0,"parents":[],"data":{"input":"tool","count":1}}
2008-08-14 12:03:22   Service.InputStore   INFO   InputStore got createCommand: [object Object]
2008-08-14 12:03:22   Service.InputStore   DEBUG   command.GUID: http://toolbar.google.com/
2008-08-14 12:03:22   Service.InputStore   DEBUG   placeID: 87085
2008-08-14 12:03:22   Service.InputStore   DEBUG   command.data.input: tool
2008-08-14 12:03:22   Service.InputStore   DEBUG   command.data.count: 1
2008-08-14 12:03:22   Service.Main   WARN   Engine exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [mozIStorageConnection.createStatement]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///D:/Firefox/UserName/AppData/Roaming/Mozilla/Firefox/Profiles/w4acyjs0.default/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/engines/input.js :: InputStore__createCommand :: line 154"  data: no]
2008-08-14 12:03:22   FaultTolerance   DEBUG   unknown (async) :: SyncEngine__sync-122 (last self.cb generated at module:engines.js:394 :: SyncEngine__sync)


I was able to fix it by changing the following line in the modules/engines/input.js file:
Line 150:
FROM:       let createStmnt = this._placeDB.createStatement("INSERT INTO moz_inputhistory (?1, ?2, ?3)");
TO:          let createStmnt = this._placeDB.createStatement("INSERT INTO moz_inputhistory VALUES (?1, ?2, ?3)");

Comment 1

[Dan Mills [:thunder]]

Saving for later, when we rewrite input history (which we will need to do), we should keep this in mind.

Comment 2

[Ed Lee :Mardak]

InputHistory is disabled for now.

Comment 3

[Tony Chung [:tchung]]

i havent seen this problem on weave 1.3.1.  Reporter, if you still can reproduce, please reopen.