Closed
Bug 450668
Opened 16 years ago
Closed 16 years ago
distribution.ini file should support livemarks
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: hello, Assigned: hello)
Details
(Keywords: fixed1.9.0.2)
Attachments
(1 file)
1.10 KB,
patch
|
Gavin
:
review+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
The distribution.ini file should support adding custom livemarks. It currently only allows bookmarks and folders.
Comment 1•16 years ago
|
||
...and pre-populating bookmark (fav)icons. :)
Assignee | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> ...and pre-populating bookmark (fav)icons. :)
That seems outside the scope of this bug.
Comment 3•16 years ago
|
||
those are the two rfe's around bookmarks that were out there. I'll create a seperate bug.
Comment 4•16 years ago
|
||
If we can get this one in on time, that'd be great.
Assignee | ||
Comment 5•16 years ago
|
||
Patch coming up, I'll just need a reviewer.
Assignee | ||
Comment 6•16 years ago
|
||
Sorry Gavin, let me know if you're busy I'll find someone else to review...
This patch adds support for livemarks in bookmarks sections (toolbar/menu/folders). To use it, add an item of type 'livemark', like this:
[BookmarksToolbar]
item.1.title=Queso
item.1.link=http://queso.com/
item.1.description=Quesos deliciosos!
item.2.title=Foo
item.2.siteLink=http://blog.mozilla.com/
item.2.feedLink=http://blog.mozilla.com/feed/
item.2.type=livemark
The above will add a bookmark and a livemark to the toolbar.
Assignee | ||
Updated•16 years ago
|
Attachment #334029 -
Flags: review? → review?(gavin.sharp)
Updated•16 years ago
|
Attachment #334029 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 7•16 years ago
|
||
Comment on attachment 334029 [details] [diff] [review]
Livemarks support v1
Requesting approval for 1.9.0.2.
Attachment #334029 -
Flags: approval1.9.0.2?
Comment 8•16 years ago
|
||
Comment on attachment 334029 [details] [diff] [review]
Livemarks support v1
Approved for 1.9.0.2. Please land in CVS. a=ss
(Talking with Dan, it looks like this isn't very relevant to get landed on trunk first since it's only used for distributions. He said he'd work on a test though.)
Attachment #334029 -
Flags: approval1.9.0.2? → approval1.9.0.2+
Comment 9•16 years ago
|
||
Can't remember if Litmus or automated was better, so take your pick. :)
Flags: in-testsuite?
Flags: in-litmus?
Assignee | ||
Comment 10•16 years ago
|
||
Landed:
Checking in distribution.js;
/cvsroot/mozilla/browser/components/distribution.js,v <-- distribution.js
new revision: 1.5; previous revision: 1.4
done
Comment 11•16 years ago
|
||
Thanks, Dan. Very much appreciated.
Updated•16 years ago
|
Keywords: fixed1.9.0.2
Assignee | ||
Comment 12•16 years ago
|
||
Committed to mozilla-central:
changeset: 18393:6d9375f4c08f
user: Dan Mills <thunder@mozilla.com>
date: Mon Aug 25 14:22:33 2008 -0700
summary: Bug 450668: Add support for livemarks to distribution.ini. r=gavin
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•