450668 - distribution.ini file should support livemarks

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dan Mills [:thunder]]

The distribution.ini file should support adding custom livemarks.  It currently only allows bookmarks and folders.

Comment 1

[Kev Needham [:kev]]

...and pre-populating bookmark (fav)icons. :)

Comment 2

[Dan Mills [:thunder]]

(In reply to comment #1)
> ...and pre-populating bookmark (fav)icons. :)

That seems outside the scope of this bug.

Comment 3

[Kev Needham [:kev]]

those are the two rfe's around bookmarks that were out there. I'll create a seperate bug.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

If we can get this one in on time, that'd be great.

Comment 5

[Dan Mills [:thunder]]

Patch coming up, I'll just need a reviewer.

Comment 6

[Dan Mills [:thunder]]

Attachment: Livemarks support v1

Sorry Gavin, let me know if you're busy I'll find someone else to review...

This patch adds support for livemarks in bookmarks sections (toolbar/menu/folders).  To use it, add an item of type 'livemark', like this:

[BookmarksToolbar]
item.1.title=Queso
item.1.link=http://queso.com/
item.1.description=Quesos deliciosos!
item.2.title=Foo
item.2.siteLink=http://blog.mozilla.com/
item.2.feedLink=http://blog.mozilla.com/feed/
item.2.type=livemark

The above will add a bookmark and a livemark to the toolbar.

Comment 7

[Dan Mills [:thunder]]

Comment on attachment 334029 [details] [diff] [review]
Livemarks support v1

Requesting approval for 1.9.0.2.

Comment 8

[Samuel Sidler (old account; do not CC)]

Comment on attachment 334029 [details] [diff] [review]
Livemarks support v1

Approved for 1.9.0.2. Please land in CVS. a=ss

(Talking with Dan, it looks like this isn't very relevant to get landed on trunk first since it's only used for distributions. He said he'd work on a test though.)

Comment 9

[Samuel Sidler (old account; do not CC)]

Can't remember if Litmus or automated was better, so take your pick. :)

Comment 10

[Dan Mills [:thunder]]

Landed:

Checking in distribution.js;
/cvsroot/mozilla/browser/components/distribution.js,v  <--  distribution.js
new revision: 1.5; previous revision: 1.4
done

Comment 11

[Kev Needham [:kev]]

Thanks, Dan. Very much appreciated.

Comment 12

[Dan Mills [:thunder]]

Committed to mozilla-central:

changeset:   18393:6d9375f4c08f
user:        Dan Mills <[e-mail]>
date:        Mon Aug 25 14:22:33 2008 -0700
summary:     Bug 450668: Add support for livemarks to distribution.ini. r=gavin