XPC_WN_{Equality,{Outer,Inner}Object} are unconditionally added to shared JSClasses

RESOLVED FIXED

Status

()

Core
XPConnect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({perf})

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
See http://hg.mozilla.org/mozilla-central/index.cgi/file/2bf53271e20d/js/src/xpconnect/src/xpcwrappednativejsops.cpp#l1348 where we can use our knowledge of the underlying object to avoid expensive calls to the named functions.

I think I've convinced jst to write the patch.
(Assignee)

Comment 1

10 years ago
Created attachment 337959 [details] [diff] [review]
Fix

Apparently I didn't, but maybe I can convince him to review it! Note that the equality hook is *not* optional.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #337959 - Flags: superreview?(jst)
Attachment #337959 - Flags: review?(jst)
Comment on attachment 337959 [details] [diff] [review]
Fix

r+sr=jst :)
Attachment #337959 - Flags: superreview?(jst)
Attachment #337959 - Flags: superreview+
Attachment #337959 - Flags: review?(jst)
Attachment #337959 - Flags: review+
(Assignee)

Comment 3

10 years ago
Pushed as http://hg.mozilla.org/mozilla-central/rev/78c6d65de496

Unfortunately, I forgot to include r and sr information in my checkin comment.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.