Closed
Bug 450692
Opened 16 years ago
Closed 16 years ago
XPC_WN_{Equality,{Outer,Inner}Object} are unconditionally added to shared JSClasses
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
(Keywords: perf)
Attachments
(1 file)
882 bytes,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
See http://hg.mozilla.org/mozilla-central/index.cgi/file/2bf53271e20d/js/src/xpconnect/src/xpcwrappednativejsops.cpp#l1348 where we can use our knowledge of the underlying object to avoid expensive calls to the named functions. I think I've convinced jst to write the patch.
Assignee | ||
Comment 1•16 years ago
|
||
Apparently I didn't, but maybe I can convince him to review it! Note that the equality hook is *not* optional.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #337959 -
Flags: superreview?(jst)
Attachment #337959 -
Flags: review?(jst)
Comment 2•16 years ago
|
||
Comment on attachment 337959 [details] [diff] [review] Fix r+sr=jst :)
Attachment #337959 -
Flags: superreview?(jst)
Attachment #337959 -
Flags: superreview+
Attachment #337959 -
Flags: review?(jst)
Attachment #337959 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/78c6d65de496 Unfortunately, I forgot to include r and sr information in my checkin comment.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•