Closed Bug 450696 Opened 12 years ago Closed 12 years ago

Update the NSPR sources in mozilla-central to NSPR 4.7.2 Beta 2.

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file, 1 obsolete file)

I'd like to update the NSPR sources in mozilla-central
to the NSPR_4_7_2_BETA2 static tag.

I will follow the procedure documented in
http://developer.mozilla.org/en/docs/Updating_NSPR_or_NSS_in_mozilla-central
Attached patch Proposed patch (obsolete) — Splinter Review
This patch was generated with "hg diff" after the
"hg addremove -n" step in
http://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central

This patch includes the fixes for the following bugs:
bug 266215
bug 330720
bug 332942
bug 430684
bug 430884
bug 431982
bug 432617
bug 434397
bug 436845
bug 450210
bug 450224
Attachment #336358 - Flags: review?(kaie)
Attachment #336358 - Flags: review?(kaie) → review+
Comment on attachment 336358 [details] [diff] [review]
Proposed patch

r=kaie

I produced a 
  cvs rdiff
between the previous and the new proposed tag

I applied that cvs rdiff to my local tree, and Wan-Teh's patch is able to revert that patch.

I conclude the patch is good.

I did this thorough review as Wan-Teh asked me to look in detail.
Attachment #336358 - Flags: review+ → review-
Comment on attachment 336358 [details] [diff] [review]
Proposed patch

Taking that back. We discovered that this patch file seems to miss the new file.

But that's probably simply because you didn't run hg addremove before creating the patch.
I ran "hg addremove" and regenerated the patch with
"hg diff".  Please review again.  Thanks.
Attachment #336358 - Attachment is obsolete: true
Attachment #336362 - Flags: review?(kaie)
Attachment #336362 - Flags: review?(kaie) → review+
Comment on attachment 336362 [details] [diff] [review]
Proposed patch (after hg addremove)

r=kaie

Thanks, this looks complete. (besides nsprpub/configure which you intentionally left out in the patch)
I pushed the changeset to mozilla-central:

$ hg push
pushing to ssh://hg.mozilla.org/mozilla-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 78 changes to 78 files

The other changeset I pushed was a so-called "merge commit"
because the first "hg push" failed:

$ hg push
pushing to ssh://hg.mozilla.org/mozilla-central/
searching for changes
abort: push creates new remote heads!
(did you forget to merge? use push -f to force)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.