450817 - nsGlobalWindow::SetNewDocument should avoid XPConnect when mInnerWindow is null

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jason Orendorff [:jorendorff]]

Attachment: v1

Bug 407216 comment 79 and 80 explain the potential problem.

There's no actual crash in trunk.  Only with a version of a patch that we aren't planning to push.  On the other hand, I see no compelling reason to leave this thumbtack lying around on the floor.

I'm not familiar with this code, but I tested the v1 patch against the test case in bug 163654 and it passes.  Mochitesting now.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 334037 [details] [diff] [review]
v1

Some Mochitests failed, and then I managed to get my linker and objective c compiler in a broken state.  So, let's hold off on this review.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 334037 [details] [diff] [review]
v1

OK, the guilty party has been found and flogged.  This guy was innocent.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 334037 [details] [diff] [review]
v1

r+sr=jst

Comment 4

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/mozilla-central/rev/caed7748c1f6