nsPluginsDirDarwin.cpp causes compile to fail GCC4.2 on Mac OS X

RESOLVED FIXED

Status

()

Core
Plug-ins
--
critical
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Simon Howes, Assigned: Simon Howes)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080814020606 Minefield/3.1a2pre
Build Identifier: 

Usual problem, extra qualification that makes GCC4.2 fail to build with OS X.



diff -r eee972f86d15 modules/plugin/base/src/nsPluginsDirDarwin.cpp
--- a/modules/plugin/base/src/nsPluginsDirDarwin.cpp	Sat Aug 16 23:27:40 2008 +1200
+++ b/modules/plugin/base/src/nsPluginsDirDarwin.cpp	Sat Aug 16 16:23:33 2008 +0100
@@ -372,7 +372,7 @@
     if (mRefNum > 0)
       ::CloseResFile(mRefNum);
   }
-  PRBool nsAutoCloseResourceObject::ResourceOpened()
+  PRBool ResourceOpened()
   {
     return (mRefNum > 0);
   }


Reproducible: Always
(Assignee)

Comment 1

10 years ago
Created attachment 334097 [details] [diff] [review]
Fix rev 1

Comment 2

10 years ago
I can confirm this. I have the same issue since a few days. I build Thunderbird from comm-central. The last time I build it on 13. August, without any problem. Since yesterday I get everytime:

/temp/src/mozilla/modules/plugin/base/src/nsPluginsDirDarwin.cpp: At global scope:
/temp/src/mozilla/modules/plugin/base/src/nsPluginsDirDarwin.cpp:375: error: extra qualification ‘nsAutoCloseResourceObject::’ on member ‘ResourceOpened’
make[6]: *** [nsPluginsDirDarwin.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [libs] Error 2


Now I will try it with this patch.

Comment 3

10 years ago
OK, now I have tested this patch. With this patch, Thunderbird builds fine again, but the build won't start (crash on startup).

Updated

10 years ago
Attachment #334097 - Flags: superreview?(roc)
Attachment #334097 - Flags: review+

Updated

10 years ago
Assignee: nobody → simon.bugzilla
Attachment #334097 - Flags: superreview?(roc) → superreview+

Comment 4

10 years ago
fixed on trunk, thanks Simon!
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.