450897 - "Delete Mail marked as Junk in Folder" doesn't work with views / quicksearch

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Was going to verify bug 312853 comment 7 but I notice "Delete Mail marked as Junk in Folder" doesn't work at all now for message views or if the quicksearch limits the displayed items. 

STR: 
1) have a few junk mails
2) quick search so you only have one mail showing
3) run the "Delete Mail...." command

Error: gDBView.viewFolder is null
Source File: chrome://messenger/content/junkCommands.js
Line: 410

Comment 1

[Kent James (:rkent)]

OK I see this, and have a patch I'm testing.

Comment 2

[Kent James (:rkent)]

Attachment: Use gMsgFolderSelected

With this patch, behavior should be:

1) When a virtual search folder is selected in the folder tree, Delete Junk in Folder (using the view) only deletes messages that appear in the virtual folder.

2) When a normal folder has a restricted view selected (for example, with tag "Important"), Delete Junk in Folder ignores the restriction, and deletes junk in the entire folder.

3) Delete Junk in Folder is disabled for cross-folder virtual views.

Comment 3

[[e-mail]]

Comment on attachment 334642 [details] [diff] [review]
Use gMsgFolderSelected

Why do quick search views sometimes not have a view folder but regular and cross-folder views do?

Comment 4

[David :Bienvenu]

nsMsgQuickSearchDBView::Open sets m_viewFolder to null so that we can distinguish between the case of a saved search over a single folder (which has a view folder and a backing db to store attributes in), and a true quick search, which doesn't have a backing db.

Comment 5

[Mark Banner (:standard8)]

Checked in, changeset id: 165:7c012b1cf8db