Closed Bug 450927 Opened 12 years ago Closed 10 years ago

SeaMonkey Buildbots should poll for domi changes as well

Categories

(SeaMonkey :: Release Engineering, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Callek, Unassigned)

References

Details

Attachments

(1 obsolete file)

Attached patch poll domi (obsolete) — Splinter Review
Following the change in Bug 437064 SeaMonkey buildbots should also poll the DOMI changesets for building.
Attachment #334141 - Flags: review?(kairo)
I'm not too sure about this because of two reasons:
1) The hidden magic the HgPoller is doing has caused enough problems with polling both mozilla-central and comm-central and the hacky workaround we're using is nothing I really like to extend to additional cases. We should have a HgPoller that cleanly allows us to deal with this, either through not setting "branch" and "revision" at all or setting them in a way that they don't conflict with the main one (the latter would perhaps enable us to make client.py pull exact revisions if different modules).
2) I don't like hardcoding repo names in master.cfg, this should be set in a var in config.py.
3) we don't poll for venkman or chatzilla changes either currently - either we should poll all of those or none, IMHO.
Comment on attachment 334141 [details] [diff] [review]
poll domi

This will go on the back burner, per IRC convo with KaiRo; when we have a buildbot poller that works for our different Hg Branches we can revisit this idea.
Attachment #334141 - Flags: review?(kairo)
Attachment #334141 - Attachment is obsolete: true
Depends on: 475012
QA Contact: build-config → build-config
KaiRo,
Has HgPoller improved since then? Otherwise, is there a bug filed about that?
DOMi and JSD are in hg, CZ and Directory are in cvs: does that make a difference?
I have no time right now to look into this, it's a very very very low priority issue for me - none of the extensions change often enough that it actually matters.
CZ is eventually moving to hg too :-)
And LDAP is planned too, probably after TB 3.0 is released :-)
Depends on: 524654
Component: Build Config → Release Engineering
QA Contact: build-config → release
(In reply to comment #4)
> I have no time right now to look into this, it's a very very very low priority
> issue for me - none of the extensions change often enough that it actually
> matters.

Thinking on this, I actually am reversing my initial thoughts on this bug, I'm marking WONTFIX for now. We can revisit when and if the extension(s) change more frequently than c-c or m-c, which is where we _really_ need to care about.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.