Closed Bug 450992 Opened 16 years ago Closed 12 years ago

Define single function for ssl redirect check in index.cgi, token.cgi and Bugzilla/Auth/Login/CGI.pm

Categories

(Bugzilla :: Administration, task)

Product:
Bugzilla
Component:
Administration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 514913

People

(Reporter: dkl, Unassigned)

References

Details

>+if ($cgi->protocol ne 'https' && Bugzilla->params->{'sslbase'} ne ''
>+    && Bugzilla->params->{'ssl'} ne 'never')

Shouldn't you define a function for this check? This code appears 3 times, so
it would be better to have it in a central place. Something similar to
ssl_require_redirect. Not sure if the function should be in CGI.pm or Util.pm.
Probably CGI.pm as it's related to it.
It doesn't need to be relnote'd.
Severity: normal → enhancement
Depends on: 428659
Keywords: relnote
Version: unspecified → 3.2
Already fixed in 3.6, see bug 514913.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Target Milestone: Bugzilla 4.4 → ---
You need to log in before you can comment on or make changes to this bug.