Closed Bug 450994 Opened 16 years ago Closed 16 years ago

"Expires" column is empty for all CAs

Categories

(Camino Graveyard :: Security, defect)

Product:
Camino Graveyard
Component:
Security
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino2.0

People

(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.17)

Attachments

(3 files)

trunk fix
1016 bytes, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review
trunk nib
11.39 KB, application/octet-stream
Details
branch fix
1.46 KB, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
There's an expiration date in all CA certificates, but for whatever reason, that date does not show up in the "Expires" column in the Certificates window.
That reason would be that I'm an idiot, and removed the necessary method in bug 411516. I didn't check the nib before deciding that the method was unused :( I'll fix this for 1.6.4.
Assignee: nobody → stuart.morgan
Flags: camino1.6.4+
Oh wait, that one was mento. But I'll still fix it ;)
Attached patch trunk fix — — Splinter Review 
The real fix is to have the column in the nib reference the date, and put a formatter on the column, rather than having a special formatting method on the class.
Attachment #334286 - Flags: superreview?(mikepinkerton)
Attached file trunk nib — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        branch fix
        — 
          — Splinter Review
      

    


  
For the branch, restore the mistakenly removed method (only using a date formatter rather than a hand-coded format) so we don't have to touch the nib.

        Attachment #334288 -
        Flags: superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 334286 [details] [diff] [review]
trunk fix

sr=pink

        Attachment #334286 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
Comment on attachment 334288 [details] [diff] [review]
branch fix

sr=pink

        Attachment #334288 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
Landed on CVS trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: regression → fixed1.8.1.17
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: