451079 - Make setting NULL to an outparam on failure ok

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

It turns out that we have lots of code that assumes setting an outparam to NULL on failure is ok. So, rather than try to rewrite the world, I'd like to suppress this class of warning... I have a trivial patch to do that, but it turns out there are some edge cases that need tightening up... I'll attach a testcase shortly.

Comment 1

[Benjamin Smedberg]

Attachment: Ignore NULL outparams, rev. 1

Comment 2

[Benjamin Smedberg]

Attachment: Null pattern needing tweaking, rev. 1

This testcase is the fairly common null pattern that needs tweaking. Basically, if you explicitly test the value of the outparam, the state machine should treat is as a NULL-set variable.

Comment 3

[Benjamin Smedberg]

Pushed the first part: http://hg.mozilla.org/mozilla-central/index.cgi/rev/1962de2d4e92

Comment 4

[David Mandelin [:dmandelin]]

Attachment: Patch for onull.cpp test case

This should take care of it. By the way, e3.cpp should now succeed. Should we just rename it to onull2.cpp and move it to that test category.

Comment 5

[Benjamin Smedberg]

Comment on attachment 334353 [details] [diff] [review]
Patch for onull.cpp test case

Looks good. Yes, go ahead and do the file-move, and I think there's an extraneous FLOW_PASS_TESTCASES in the patch.

Comment 6

[David Mandelin [:dmandelin]]

Attachment: Patch for checkin

Comment 7

[David Mandelin [:dmandelin]]

Attachment: Bundle version of onull2.diff

Comment 8

[Benjamin Smedberg]

pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/3390347493fd

Comment 9

[Benjamin Smedberg]

You forgot to add/rename the testcases in the previous commit. I've fixed this on mozilla-central with the following commit:

http://hg.mozilla.org/mozilla-central/rev/a4d2e6549f7f