The return value of read() function should check in nsRandomAccessInputStream::readline instead of invoking failed().

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Core
XPCOM
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

({fixed1.8.1.18})

unspecified
mozilla1.9.1b1
fixed1.8.1.18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080702 Ubuntu/8.04 (hardy) Firefox/2.0.0.15 Kazehakase/0.5.4
Build Identifier: 

The return value of read() function should check in nsRandomAccessInputStream::readline.

I guess TB48808062, TB48797096 etc. are caused by this issue.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

9 years ago
Created attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]
Attachment #334398 - Flags: review?(brendan)
(Assignee)

Updated

9 years ago
Attachment #334398 - Flags: approval1.8.1.17?
Comment on attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]

Looks good to me but I would be glad if Benjamin could sr+.

/be
Attachment #334398 - Flags: superreview?(benjamin)
Attachment #334398 - Flags: review?(brendan)
Attachment #334398 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]

Please get the requested super-review before requesting approval to land the patch. You can find benjamin on irc.mozilla.org
Attachment #334398 - Flags: approval1.8.1.17?
Attachment #334398 - Flags: superreview?(benjamin) → superreview+
(Assignee)

Comment 4

9 years ago
Comment on attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]

The patch will raise stability.
Attachment #334398 - Flags: approval1.8.1.17?
Comment on attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]

This will have to get looked at in 1.8.1.18. We're frozen.
Attachment #334398 - Flags: approval1.8.1.17? → approval1.8.1.18?
Attachment #334398 - Flags: approval1.8.1.18? → approval1.8.1.18+
Comment on attachment 334398 [details] [diff] [review]
Patch
[Checkin: Comment 7]

Approved for 1.8.1.18, a=dveditz for release-drivers
Keywords: checkin-needed

Updated

9 years ago
Assignee: nobody → poincare
http://hg.mozilla.org/mozilla-central/rev/1d02d37faf24
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
(Assignee)

Updated

9 years ago
Whiteboard: [checkin-needed: 1.8 branch]
Attachment #334398 - Attachment description: Patch → Patch [Checkin: Comment 7]
Fix checked into the 1.8 branch
Keywords: checkin-needed → fixed1.8.1.18
Whiteboard: [checkin-needed: 1.8 branch]
You need to log in before you can comment on or make changes to this bug.