use jemalloc in fennec for maemo

RESOLVED FIXED

Status

Toolkit Graveyard
XULRunner
P1
normal
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: dougt, Assigned: Stuart Parmenter)

Tracking

Trunk
x86
Mac OS X
Dependency tree / graph
Bug Flags:
wanted-fennec1.0 +

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
currently we are not using jemalloc in fennec.  we should fix this.
(Reporter)

Updated

9 years ago
Flags: wanted-fennec1.0?
(Assignee)

Updated

9 years ago
Assignee: nobody → pavlov
Flags: wanted-fennec1.0? → wanted-fennec1.0+
Target Milestone: --- → Fennec A1
(Assignee)

Comment 1

9 years ago
bsmedberg, ted: since we're using xulrunner-stub as our application piece, we need it to link against jemalloc.  I'm not sure how to do this short of making it always link against jemalloc (perhaps that is OK).  Thoughts?
as discussed on IRC, the "safe" way to do this is probably to statically link xulrunner-stub against jemalloc (dynamic linking won't work well because you don't actually know where libjemalloc.so lives until the "find libxul" code runs.
(Assignee)

Comment 3

9 years ago
Created attachment 335101 [details] [diff] [review]
ubuntu's patch to link jemalloc in to xulrunner-stub
(Assignee)

Comment 4

9 years ago
Created attachment 335102 [details] [diff] [review]
ubuntu patch to make jemalloc build statically
(Assignee)

Updated

9 years ago
Attachment #335101 - Flags: review?(benjamin)
(Assignee)

Comment 5

9 years ago
Comment on attachment 335102 [details] [diff] [review]
ubuntu patch to make jemalloc build statically

i'm unsure if this patch is right for linux... do we always want this to be static?  i'm not sure what all our different shared/static/libxul/notlibxul/embedding/etc cases are..
Attachment #335102 - Flags: review?(benjamin)
Attachment #335102 - Flags: review?(benjamin) → review+
Comment on attachment 335101 [details] [diff] [review]
ubuntu's patch to link jemalloc in to xulrunner-stub

you want $(call EXPAND_LIBNAME_PATH,jemalloc,$(DEPTH)/memory/jemalloc)
Attachment #335101 - Flags: review?(benjamin) → review-
(Assignee)

Updated

9 years ago
Priority: -- → P1
(Assignee)

Comment 7

9 years ago
Created attachment 335583 [details] [diff] [review]
updated patch to link jemalloc to xulrunner-stub
Attachment #335101 - Attachment is obsolete: true
Attachment #335583 - Flags: review?(benjamin)
Attachment #335583 - Flags: review?(benjamin) → review+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 8

9 years ago
If I use firefox-bin not xulrunner to start Firefox on Linux, where does jemalloc live in?

Comment 9

9 years ago
I just did a release build on Linux, I didn't find malloc() implementation in dist/bin binaries.
(Assignee)

Comment 10

9 years ago
As I understand it, jemalloc should still be getting linked in via browser/app/Makefile.in for firefox... bsmedberg, is that right?
I think so, and therefore part of firefox-bin itself.

Comment 12

9 years ago
Interesting.
nsBrowserApp.cpp doesn't explicit use malloc() function, so linking libjemalloc.a into firefox-bin doesn't have any effect.

Comment 13

9 years ago
We can use MKSHLIB_FORCE_ALL if we want.
Depends on: 453569
Depends on: 436449

Updated

9 years ago
Depends on: 454192
Component: General → XULRunner
Product: Fennec → Toolkit
QA Contact: general → xulrunner
Target Milestone: Fennec A1 → ---
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.