The default bug view has changed. See this FAQ.

Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default

VERIFIED FIXED in mozilla1.9.1b1

Status

()

Core
Widget
--
minor
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: graememcc)

Tracking

({testcase})

Trunk
mozilla1.9.1b1
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

9 years ago
Created attachment 334532 [details]
testcase (uses enhanced privileges)

See testcase.
When clicking on the first 2 buttons, you can see the find highlighted text selection go to green/blue, respectively.
However, with the 3rd and 4th button, I would expect the find highlighted text selection to go to the default color (which is yellow in my case).
This doesn't happen for me, it only happens for me after I have restarted my browser.

It's not a big deal, but extension writers might find this annoying.
(Assignee)

Comment 1

9 years ago
Created attachment 334536 [details]
testcase for textSelectBackground

This doesn't appear to be unique to ui.textHighlightBackground.

The above testcase exhibits the same behavior for ui.textSelectBackground
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 2

9 years ago
Created attachment 334679 [details] [diff] [review]
Patch v1

So, this is definitely not unique to the ui.textHighlightBackground pref: it is in fact the same for for all ui.* color preferences.

nsXPLookAndFeel observes the various color prefs it cares about, and if the pref is set or changed to a color string, nsXPLookAndFeel will cache the new value for future lookups. However, if the value is cleared, there's currently no mechanism to say "stop using the cached value, and look up the default".

Not sure how to test this...
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
Attachment #334679 - Flags: superreview?(roc)
Attachment #334679 - Flags: review?(roc)
(Assignee)

Updated

9 years ago
Assignee: graememcc_firefox → nobody
Status: ASSIGNED → NEW
Component: Find Toolbar → Widget
Product: Toolkit → Core
QA Contact: fast.find → general
Comment on attachment 334679 [details] [diff] [review]
Patch v1

Excellent, thanks!
Attachment #334679 - Flags: superreview?(roc)
Attachment #334679 - Flags: superreview+
Attachment #334679 - Flags: review?(roc)
Attachment #334679 - Flags: review+
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
Assignee: nobody → graememcc_firefox
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Summary: Setting ui.textHighlightBackground pref to empty string or removing pref doesn't reset directly default highlight → Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default
http://hg.mozilla.org/mozilla-central/rev/6a6a0717bbfd
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
(Reporter)

Comment 5

9 years ago
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080908091724 Minefield/3.1b1pre
(Reporter)

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.