451232 - Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase (uses enhanced privileges)

See testcase.
When clicking on the first 2 buttons, you can see the find highlighted text selection go to green/blue, respectively.
However, with the 3rd and 4th button, I would expect the find highlighted text selection to go to the default color (which is yellow in my case).
This doesn't happen for me, it only happens for me after I have restarted my browser.

It's not a big deal, but extension writers might find this annoying.

Comment 1

[Graeme McCutcheon [:graememcc]]

Attachment: testcase for textSelectBackground

This doesn't appear to be unique to ui.textHighlightBackground.

The above testcase exhibits the same behavior for ui.textSelectBackground

Comment 2

[Graeme McCutcheon [:graememcc]]

Attachment: Patch v1

So, this is definitely not unique to the ui.textHighlightBackground pref: it is in fact the same for for all ui.* color preferences.

nsXPLookAndFeel observes the various color prefs it cares about, and if the pref is set or changed to a color string, nsXPLookAndFeel will cache the new value for future lookups. However, if the value is cleared, there's currently no mechanism to say "stop using the cached value, and look up the default".

Not sure how to test this...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 334679 [details] [diff] [review]
Patch v1

Excellent, thanks!

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/6a6a0717bbfd

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080908091724 Minefield/3.1b1pre