Closed Bug 451244 Opened 11 years ago Closed 11 years ago

nsNavHistory does not use threadsafe refcounting

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1a2

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 1 obsolete file)

Turns out, if we try to use the places database connection off of the main thread (which is OK), we'll assert because nsNavHistory does not use threadsafe addref and release.

It's not clear if I need to ensure main threaded-ness normally, but that should probably be in a different bug.
Blocks: 450290
Attached patch v1.0 (obsolete) — Splinter Review
Attachment #334544 - Flags: review?(dietrich)
Whiteboard: [has patch][needs revi
Whiteboard: [has patch][needs revi → [has patch][needs review dietrich]
Comment on attachment 334544 [details] [diff] [review]
v1.0

r=me
Attachment #334544 - Flags: review?(dietrich) → review+
Whiteboard: [has patch][needs review dietrich] → [has patch][has reviews][can land]
Keywords: checkin-needed
Attached patch v1.1Splinter Review
for checkin (contains commit message and user)
Attachment #334544 - Attachment is obsolete: true
Pushed as 17109:f5560c23f25e.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews][can land]
You need to log in before you can comment on or make changes to this bug.