Closed
Bug 451244
Opened 18 years ago
Closed 18 years ago
nsNavHistory does not use threadsafe refcounting
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
848 bytes,
patch
|
Details | Diff | Splinter Review |
Turns out, if we try to use the places database connection off of the main thread (which is OK), we'll assert because nsNavHistory does not use threadsafe addref and release.
It's not clear if I need to ensure main threaded-ness normally, but that should probably be in a different bug.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #334544 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [has patch][needs revi
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [has patch][needs revi → [has patch][needs review dietrich]
|
||
Comment 2•18 years ago
|
||
Comment on attachment 334544 [details] [diff] [review]
v1.0
r=me
Attachment #334544 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch][has reviews][can land]
|
|
Assignee | |
Updated•18 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•18 years ago
|
||
for checkin (contains commit message and user)
Attachment #334544 -
Attachment is obsolete: true
|
||
Comment 4•18 years ago
|
||
Pushed as 17109:f5560c23f25e.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews][can land]
You need to log in
before you can comment on or make changes to this bug.
Description
•