451258 - Unused var in customizeCharset.js

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Stefan [:stefanh]]

Attachment: Remove the var

Really minor, but I just happened to have a patch

So, I found an unused var in suite/common/pref/pref-languages.js - I MXR:ed for it and noted that there where 4 files with this unused variable... One file is now removed, the 2 files in comm-central are being re-worked, so soon it's only the toolkit one left :-)

Comment 1

[Stefan [:stefanh]]

( The joy of forking )

Comment 2

[Stefan [:stefanh]]

Thanks. I'll land this after the freeze.

Comment 3

[Aiko]

Comment on attachment 334569 [details] [diff] [review]
Remove the var

> function RemoveActiveCharset()
> {
>   var listbox = document.getElementById('active_charsets');
>   var nextNode = null;
>   var numSelected = listbox.selectedItems.length;
>-  var deleted_all = false;
> 
>   var numSelectedItems = listbox.selectedItems.length;
>   for (count = 0; count < numSelectedItems; count ++) {
>     listbox.removeChild(listbox.selectedItems[0]);
>   }
> 
>   listbox.clearSelection();

- numSelected and nextNode are not used either.
- count is not declared.

Comment 4

[Stefan [:stefanh]]

Yeah, thanks. You actually get a warning in the error console from the undeclared var. The function was changed for 3 years ago (bug 301742), the unused vars etc have been there since then. Anyway, I'll fix that in a few days.

Comment 5

[Stefan [:stefanh]]

Attachment: Fix declaration and remove some more vars

OK, so this turns out that we're fixing a "real" bug here... Thanks to Aiko for catching this.

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/4fd431338f91