Closed Bug 451268 Opened 11 years ago Closed 11 years ago

TM: Double check that its safe to not have a loop check after the unrolled first iteration in a tree call

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Unassigned)

References

Details

js_LoopEdge is triggered before we actually compile the underlying branch opcode, so we never emit code for it on trace. Double check whether thats safe to do.
The comment above is incorrect. We do trace IFEQ/IFNE first. The resulting guards is simply constant folded in most case. I verified that the guard is emitted if constant folding is impossible, i.e.:

function f(N) {
	for (var i = 0; i < 100; ++i)
		for (var j = 0; j < N; ++j)
			;
}

f(50);

r=shaver
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.