Closed Bug 451274 Opened 16 years ago Closed 7 years ago

Use 3D Objects foreground color for status bar, toolbar, and tabs

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: adelfino, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [polish-visual][polish-easy][polish-p4])

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080819034536 Minefield/3.1a2pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080819034536 Minefield/3.1a2pre Compare between Minefield and Notepad status bar background and foreground colors. I used Windows Classic style, with Windows Standard color scheme, changing 3D Objects background color to #555753 and foreground color to #FFF. Notepad uses 3D Objects foreground color for status bar text, while Minefield does not. Reproducible: Always
Component: General → Theme
QA Contact: general → theme
Attached image Comparison.
Version: unspecified → Trunk
There are three foreground colors in Windows classic: * window / message box: default * 3D: used for button text, status bars, toolbars, tabs, and the arrows on the scrollbar, dropdown, and spinner buttons * menu: used for both the menu bar (even when its appearance is that of a 3D button) and the actual menu frames We deviate from standard Windows behavior in these areas: * We use window instead of 3D color for the status bar * We use window instead of 3D color for toolbar elements * We use window instead of 3D color for tabs * We use window instead of 3D color for spinner arrows In almost all themes, these three colors have the same values, which is why discrepancies in our usage goes unnoticed. Aside: It should also be noted that these colors are classic colors and apply only to widgets that are drawn classically. uxthemed widgets use colors defined by the theme for that element, which is why in Luna, you will notice that changing colors around will have no effect on apps that are uxthemed (note that menus in Luna are still drawn classically--just without a 3D bevel--and are not uxthemed, so they do follow changes of classic system colors) (legacy apps that don't have the manifest to use the new uxthemed controls will still follow classic system colors on Luna). We currently do not pull out uxtheme colors (except in a few cases) and just use classic colors with uxtheme (which usually works because they are set to the same color). In the long run, we will probably want to address this issue (by having setting a foreground color through -moz-appearance and having that override any color set in CSS), but that's a matter for another bug. I thought I'd just mention this, in case some asks "what about Luna/Aero/etc.?"
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Use 3D Objects foreground color for status bar → Use 3D Objects foreground color for status bar, toolbar, and tabs
Marking blocking‑firefox3.1 as I can't mark wanted‑firefox3.1
Flags: blocking-firefox3.1?
Flags: wanted-firefox3.1+
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1-
Keywords: polish
Whiteboard: [polish-visual][polish-easy]
Blocks: 430366
This bug's priority relative to the set of other polish bugs is: P4 - Polish issue that is rarely encountered, and is easily identifiable. Clearly broken, but only effects a limited set of OS themes.
Whiteboard: [polish-visual][polish-easy] → [polish-visual][polish-easy][polish-p4]
We don't support having a status bar anymore, and this doesn't seem relevant for tabs and toolbars anymore either. (Windows Classic itself is obsolete now.)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: