451346 - Implement nativehyperlinktext to get readable URLs in the location bar autocomplete

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Peter Weilbacher]

Attachment: fix

Mozilla/5.0 (OS/2; U; Warp 4.5; de; rv:1.9.1a2pre) Gecko/20080815132256 Minefield/3.1a2pre

I think it is since bug 426732 and bug 437358 the URL in the history dropdown of the Firefox URL bar appears light grey which makes it almost unreadable for me (the background of that window is a beigish yellow).

Adding eColor__moz_nativehyperlinktext to our nsLookAndFeel.cpp should be good enough. Although my build with this hasn't completed, I'll attach the patch which uses blue for that color as I don't think we have any color property on OS/2 that we could otherwise query.

Comment 1

[Walter Meinl]

(In reply to comment #0)
> Created an attachment (id=334653) [details]
> fix
R+ as per not existing authorization in a comment. Looks nice. I think _blue_ is as usual a good choice on this platfom. History and autocomplete are working, give it a push.

Comment 2

[Peter Weilbacher]

Comment on attachment 334653 [details] [diff] [review]
fix

As per comment 1.

Walter, in case you are on IRC sometimes, you should be able to find someone to give you Bugzilla privileges for reviews.

Comment 3

[Mike Kaply [:mkaply]]

I gave Walter the necessary privileges

Comment 4

[Walter Meinl]

(In reply to comment #3)
> I gave Walter the necessary privileges
> 

Thank you Mike, it's a pleasure and honor for me :)

Comment 5

[Peter Weilbacher]

Pushed to mozilla-central - changeset - 18498:9f2072d1f543