451390 - In comm-central <client.py>, add an |options.skip_ldapsdk|

Status: VERIFIED FIXED

(MailNews Core :: Build Config, enhancement)

Description

[Serge Gautherie (:sgautherie)]

[I guess I'm +/- abusing the component, but anyway...]

{{
LDAPCSDK_CO_TAG = 'LDAPCSDK_6_0_3_CLIENT_BRANCH'

    if not options.skip_cvs:
        if not options.skip_calendar:
          do_cvs_checkout(CALENDAR_DIRS, CALENDAR_CO_TAG, options.cvsroot, options.cvs, '')
        do_cvs_checkout(LDAPCSDK_DIRS, LDAPCSDK_CO_TAG, options.cvsroot, options.cvs, '')
}}

The tag rarely changes: no point checking it out every time.

Comment 1

[Robert Kaiser]

(In reply to comment #0)
> The tag rarely changes: no point checking it out every time.

There's also not much harm, as it only checks and doesn't really pull any file if nothing changed.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)

Sure, I did not mean that it downloaded it every time,
only that it's a small waste of time/bandwidth/log-space/etc.

Comment 3

[Justin Wood (:Callek)]

Attachment: v1

not convinced we even need this, but I don't see a harm in adding the option. Low-hanging-fruit

Comment 4

[Robert Kaiser]

Comment on attachment 340273 [details] [diff] [review]
v1

I agree that I don't see it as much needed, but adding it doesn't harm anyone.

Comment 5

[Justin Wood (:Callek)]

$ hg outgoing -v
running "ssh hg.mozilla.org "hg -R comm-central/ serve --stdio""
comparing with ssh://hg.mozilla.org/comm-central/
searching for changes
changeset:   445:fff1a4dbb400
tag:         tip
user:        Justin Wood <[e-mail]>
date:        Fri Sep 26 18:19:18 2008 -0400
files:       client.py
description:
Bug 451390, In comm-central <client.py>, add an |options.skip_ldap|
r=pending

$ hg push
pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

Comment 6

[Serge Gautherie (:sgautherie)]

V.Fixed, by using this option locally.

Comment 7

[Justin Wood (:Callek)]

gyah, meant to fix checkin comment before I actually checked in... r=KaiRo on that of course...