451405 - Provide detailed output from junk bayesian filter

Status: RESOLVED FIXED

(MailNews Core :: Filters, enhancement)

Description

[Kent James (:rkent)]

Primarily for use by extensions, I'd like to add an additional call to the bayesian filter code that provides detailed results on the analysis of a particular message, including the tokens used and their individual contribution to the final score.

Comment 1

[Kent James (:rkent)]

Attachment: adds a detail listener and interface

Here I add a detail listener with the details of the calculation. I will also post an extension that detailed results.

Comment 2

[Kent James (:rkent)]

Attachment: Extension to demonstrate use

This modified JunQuilla extension adds a message context entry "Junk Detail" which will show the tokens used for the first selected message.

Comment 3

[Kent James (:rkent)]

Although it would be nice to have this for beta 2, it is not critical.

Comment 4

[David :Bienvenu]

Comment on attachment 360370 [details] [diff] [review]
adds a detail listener and interface

can we do w/o the prints in the test case?

+    print("Details for " + aMsgURI);
+    for (var i = 0; i < aTokenString.length; i++)
+    {
+      print("Percent " + aTokenPercents[i] +
+            " Running " + aRunningPercents[i] +
+            " Token " + aTokenString[i]);

Comment 5

[Kent James (:rkent)]

I'd be curious to know what the policies or current practice is on such printouts. I've often left a little bit of printout like that in test code, as it only shows up in the logs, and can be useful to see where you are when a test fails.

Comment 6

[David :Bienvenu]

I'm curious as well, actually.

Comment 7

[Kent James (:rkent)]

David, is there any chance that you could do the review for this as well, so that it could land before the cutoff for TB beta 2?

Comment 8

[David :Bienvenu]

Comment on attachment 360370 [details] [diff] [review]
adds a detail listener and interface

yes, I can take the review, since I know Mark has some reviews I need :-)

Comment 9

[David :Bienvenu]

I've landed this for b2