Closed
Bug 451405
Opened 16 years ago
Closed 15 years ago
Provide detailed output from junk bayesian filter
Categories
(MailNews Core :: Filters, enhancement)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: rkent, Assigned: rkent)
Details
Attachments
(2 files)
13.47 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
42.11 KB,
application/x-xpinstall
|
Details |
Primarily for use by extensions, I'd like to add an additional call to the bayesian filter code that provides detailed results on the analysis of a particular message, including the tokens used and their individual contribution to the final score.
Assignee | ||
Comment 1•15 years ago
|
||
Here I add a detail listener with the details of the calculation. I will also post an extension that detailed results.
Attachment #360370 -
Flags: superreview?(bienvenu)
Attachment #360370 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•15 years ago
|
||
This modified JunQuilla extension adds a message context entry "Junk Detail" which will show the tokens used for the first selected message.
Assignee | ||
Comment 3•15 years ago
|
||
Although it would be nice to have this for beta 2, it is not critical.
Whiteboard: [waiting review bienvenu, standard8]
Target Milestone: --- → Thunderbird 3.0b3
Comment 4•15 years ago
|
||
Comment on attachment 360370 [details] [diff] [review] adds a detail listener and interface can we do w/o the prints in the test case? + print("Details for " + aMsgURI); + for (var i = 0; i < aTokenString.length; i++) + { + print("Percent " + aTokenPercents[i] + + " Running " + aRunningPercents[i] + + " Token " + aTokenString[i]);
Attachment #360370 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 5•15 years ago
|
||
I'd be curious to know what the policies or current practice is on such printouts. I've often left a little bit of printout like that in test code, as it only shows up in the logs, and can be useful to see where you are when a test fails.
Comment 6•15 years ago
|
||
I'm curious as well, actually.
Assignee | ||
Comment 7•15 years ago
|
||
David, is there any chance that you could do the review for this as well, so that it could land before the cutoff for TB beta 2?
Updated•15 years ago
|
Attachment #360370 -
Flags: review?(bugzilla) → review?(bienvenu)
Comment 8•15 years ago
|
||
Comment on attachment 360370 [details] [diff] [review] adds a detail listener and interface yes, I can take the review, since I know Mark has some reviews I need :-)
Comment 9•15 years ago
|
||
I've landed this for b2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0b2
Updated•15 years ago
|
Attachment #360370 -
Flags: review?(bienvenu) → review+
Updated•15 years ago
|
Whiteboard: [waiting review bienvenu, standard8] → [
Updated•15 years ago
|
Whiteboard: [
Assignee | ||
Updated•15 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•