451445 - Use the small sidebar search bar on "How to Contribute" articles and forum threads

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Majken Connor [:Kensie]]

Need to update the css/modules for the how to contribute category.

Comment 1

[Chris Ilias [:cilias]]

What is the "old search bar"?

Comment 2

[Majken Connor [:Kensie]]

the big one across the top rather than the small one on the side.

Comment 3

[Chris Ilias [:cilias]]

Looking at:
http://support.mozilla.com/en-US/kb/Adding+screenshots
http://support.mozilla.com/en-US/kb/Approving+articles+and+edits
http://support.mozilla.com/en-US/kb/Best+Practices+for+Support+Documents
http://support.mozilla.com/en-US/kb/Creating+articles
http://support.mozilla.com/en-US/kb/Editing+articles

That's the way it is. Fixed?

Comment 4

[Majken Connor [:Kensie]]

Yeah looking back this was confusing:

How to contribute pages have the "old" (big search bar at the top) search bar. They should have the new sidebar one.

Comment 5

[David Tenser [:djst]]

Let's target this for 0.8. Another thing is that forum threads also still use the big search bar; I think they should also move to the smaller one. To keep things simple we could just extend this bug to cover that.

Comment 7

[Paul Craciunoiu [:paulc]]

I think we should make a list of where exactly the big search bar should stay, and remove it from everywhere else. Typically we would show the small search when viewing content that is not a list of some sort (i.e. the user is already where he wants to be, or is focused on reading, more than on searching).

So, where is it important to have big vs small?

Comment 8

[Majken Connor [:Kensie]]

Basically big should be used where the primary function of the page is for the user to search. It should be small in the case that you said, the user has found something and the primary function of the page is something else.

I'd keep big on homepage, forum homepage, search results, ask a question.

Comment 9

[David Tenser [:djst]]

Actually it's more narrow than that. We want the big search on the homepages (normal, inproduct, forum) only. 

Aside from that, we have a template that allows us to use the big search on special pages (for example, the ask a question page IFF the user hasn't already searched; if the user comes to ask a question from the search results page, we shouldn't show the big search box, which essentially means we need two separate "ask a question" pages). See bug 476313 for a base template with the small search.

This bug is about changing the appearance of the "How to Contribute" template, which is a collection of articles for contributors and as such should be treated in the same way as our other articles but of course with the same heading as it's using today.

Comment 10

[Paul Craciunoiu [:paulc]]

Attachment: Sample article without big search

I don't think the page looks good without the big search bar, unless we change the styling. Should we just make the inproduct pages look just like the KB ones except for the menu in the header?
Here are some differences that are problematic:
* "Firefox Help" heading... why is that useful?
* Wasteful space below the "Firefox Help" heading
* Header background makes the actions box and the top of the article look weird (goes down too much).

Comment 11

[Paul Craciunoiu [:paulc]]

Attachment: Proposed fix v1

Now the only differences are the mini header + no breadcrumb.

Comment 12

[David Tenser [:djst]]

Comment on attachment 367847 [details]
Proposed fix v1

With the sidebar search bar added, looks good.

Comment 13

[Paul Craciunoiu [:paulc]]

r23459 / r23460
Needs testing to make sure I only changed the right pages.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Is http://support-stage.mozilla.org/en-US/kb/Improving+articles a good sample article against which to verify changes?

Comment 15

[Paul Craciunoiu [:paulc]]

It works when logged in, on
https://support-stage.mozilla.org/en-US/kb/Improving+articles
I see it cached when on http://

Comment 16

[Chris Ilias [:cilias]]

There should be a search box in the sidebar.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/en-US/kb/Improving+articles when logged both in and out.

Comment 18

[Paul Craciunoiu [:paulc]]

Should we also remove the big search bar from the "Ask a question" form at
https://support-stage.mozilla.org/tiki-view_forum.php?locale=en-US&forumId=1&openpost=1 ?

Comment 19

[David Tenser [:djst]]

Reopening.

* The search box is placed _under_ the "Contributor Tools" box; should be above like for other templates.

* The drop shadow on the right side is cut off. Compare with e.g. http://support.mozilla.com/kb/Bookmarks

Comment 20

[Chris Ilias [:cilias]]

I'm seeing the Search box above the Contributor Tools box.

Comment 21

[David Tenser [:djst]]

Yes, it's above now. The shadow is still cut off on the right side though. Compare with the normal KB view.

Comment 22

[Paul Craciunoiu [:paulc]]

David: which URL does this apply for?

Comment 23

[David Tenser [:djst]]

I'll file a separate bug for it.

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #23)
> I'll file a separate bug for it.

David filed bug 485144.

Comment 25

[David Tenser [:djst]]

Reopening (again). Apparently this fix only applies to the en-US locale. All translations still have the big search box. See:

https://support-stage.mozilla.org/sv-SE/kb/Adding+screenshots?bl=n
https://support-stage.mozilla.org/en-US/kb/Adding+screenshots

Comment 26

[Paul Craciunoiu [:paulc]]

r23941 / r23942
Oops, forgot to "translate" the titles I was testing for in my if's. Done that now and tested. Seems fine.

If this gets pushed without the commit above, the pages will look like they used to for other locales.

Thanks David, good catch!

Comment 27

[Stephen Donner [:stephend] Not actively reading bugmail]

Both URLs in comment 25 are showing the small search box on the right, for me.