451453 - [silme] (file.py) log instead of raise an exception in FileClient.getSource()

Status: RESOLVED WONTFIX

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Attachment: patch

It is not possible to override this exception if getSource() has been called from another method inside Silme. And without that you can currently only override the exception of the whole method, e.g. getL10nLocales(), which causes a lot of trouble.

With the patch attached we can log the exception without breaking the methods calling getSource().

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

The patch looks good. What worries me is that it adds a new dependency very much in the middle of the library.

I have been trying to avoid thinking about logging solution but I know we'll have to face it. logging sounds like a default python package for that, so the whole concept makes sense, it's just that I have no experience with this... Pike - your opinion?

Comment 2

[Stefan Plewako [:stef]]

It could be very useful to have error list for each l10nPackage, eg like l10nPackage.errors[file][type|path|msg] so we could easily reuse such information with diff, tests or reporting.

Comment 3

[Axel Hecht [:Pike]]

What Stefan said. In my compare-locales, I'm reporting parsing errors (grammar or encoding alike) on the same level as I report diffs.

Comment 4

[Adrian Kalla [:adriank]]

Stef, Axel: I like this idea. Lets see how it can be done...

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

the only design choice we have to make is wherever we want to attach errors/exceptions/problems to l10nObject/l10nPackage or to external object.

I'm a little bit worried about the sanity of the API if we'll try to mix such informations into l10nPackage so automatically I'd prefer to get it externally from l10nPackage.

For example we could extend logger to store any errors per package.

Pike? Stef? Adrian?

Comment 6

[Stefan Plewako [:stef]]

As I see this we need an easy way to handle reader errors - eg when I iterate through objects/packages in subL10nPackage I need to know what parts of file set (like images) vaporized - I consider such information as critical for reliability.

If we really don't want to store such information directly in l10nPackage I would like to have getL10nPackageErrors(l10nPakcakge) method that will return all errors info (not recursively, all errors set is last thing that I want to deal with) and have option for not logging to file.

Comment 7

[Adrian Kalla [:adriank]]

the Problem will be solved in a different way (keywords: logger/logging)

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

bug 452686 for reference.