Closed
Bug 451463
Opened 16 years ago
Closed 16 years ago
mozStorageStatement needs threadsafe refcounting
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
If you create a statement on a background thread, it will end up getting garbage collected on the main thread. The sqlite3_stmt object is threadsafe, but I'd rather not make the guarantee that mozIStorageStatement is yet. That'll add some locking that I just don't think we'd want.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #334792 -
Flags: review?(bent.mozilla)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs reivew bent]
Comment on attachment 334792 [details] [diff] [review] v1.0 Oh, sorry for the delay, this looks fine.
Attachment #334792 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs reivew bent] → [has patch][has review][can land]
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/cef09646fc13
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Target Milestone: --- → mozilla1.9.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•