EmptyEnumeratorImpl::QueryInterface() doesn't include nsIUTF8StringEnumerator

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
XPCOM
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: jacob berkman, Assigned: florian)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
fixed1.9.1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed1.9.1b4])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1

Not much more to say.  The class itself derives from nsIUTF8StringEnumerator, but it's missing from the NS_IMPL_QUERY_INTERFACE() macro.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Comment 1

10 years ago
Created attachment 334824 [details] [diff] [review]
add nsIUTF8StringEnumerator to the list of interfaces EmptyEnumeratorImpl implements
(Assignee)

Comment 2

10 years ago
Created attachment 360073 [details] [diff] [review]
patch (including nsIStringEnumerator in the list of implemented interfaces)
[Checkin: Comment 4 & 5]

The EmptyEnumeratorImpl class inherits from nsISimpleEnumerator, nsIUTF8StringEnumerator and nsIStringEnumerator so I guess all the 3 should be listed in the NS_IMPL_QUERY_INTERFACE macro.

I don't think there is anything to test for such a trivial patch, but I may be wrong. Static checking that C++ classes that inherit from XPCOM interfaces actually implement QueryInterface for them may be nice, but I'm not sure it's possible to do (or worth the effort).
Attachment #334824 - Attachment is obsolete: true
Attachment #360073 - Flags: superreview?(benjamin)
Attachment #360073 - Flags: review?(benjamin)
(Assignee)

Comment 3

10 years ago
This bug is the actual cause of bug 426968.
Blocks: 426968
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Version: unspecified → Trunk

Updated

10 years ago
Attachment #360073 - Flags: superreview?(benjamin)
Attachment #360073 - Flags: superreview+
Attachment #360073 - Flags: review?(benjamin)
Attachment #360073 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/cc177f5d2404
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee: nobody → florian
Flags: in-testsuite-
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2a1
Attachment #360073 - Flags: approval1.9.1?

Updated

9 years ago
Attachment #360073 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 360073 [details] [diff] [review]
patch (including nsIStringEnumerator in the list of implemented interfaces)
[Checkin: Comment 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/cfe7ceff1815
Attachment #360073 - Attachment description: patch (including nsIStringEnumerator in the list of implemented interfaces) → patch (including nsIStringEnumerator in the list of implemented interfaces) [Checkin: Comment 4 & 5]
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1b4]
You need to log in before you can comment on or make changes to this bug.