Closed Bug 451504 Opened 12 years ago Closed 12 years ago

js/src/jslock.cpp failed to compile on Solaris x86

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
OpenSolaris
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

patch v2
580 bytes, patch
igor
: review+
Details | Diff | Splinter Review
No longer blocks: 417131
see bug 417131 comment #76
Blocks: 417131
Attached patch patch (obsolete) — — Splinter Review
Assignee: general → ginn.chen
Status: NEW → ASSIGNED
Attachment #334832 - Flags: review?(igor)
Comment on attachment 334832 [details] [diff] [review]
patch

> #else
> 
>+#if JS_HAS_NATIVE_COMPARE_AND_SWAP
> #error "JS_HAS_NATIVE_COMPARE_AND_SWAP should be 0 if your platform lacks a compare-and-swap instruction."
>+#endif

#else ... #if here can be compined into the single #elif. r+ with that fixed.
Attached patch patch v2 — — Splinter Review
Attachment #334832 - Attachment is obsolete: true
Attachment #334839 - Flags: review?(igor)
Attachment #334832 - Flags: review?(igor)
Attachment #334839 - Flags: review?(igor) → review+
Pushed
http://hg.mozilla.org/index.cgi/mozilla-central/rev/c0666d880dcd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.