Closed Bug 451527 Opened 16 years ago Closed 16 years ago

Add a strong type convention for Mingw build

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b1

People

(Reporter: Techrazy.Yang, Assigned: Techrazy.Yang)

Details

Attachments

(1 file, 2 obsolete files)

Third one [Checkin: Comment 6]
676 bytes, patch
bzbarsky
: review+
jst
: superreview+
Details | Diff | Splinter Review
Attached patch The little patch (obsolete) — — Splinter Review 
The Mingw GCC compiler can't figure the convention itself, so I help it...
Attachment #334853 - Flags: review?(bzbarsky)
Blocks: 449557
Comment on attachment 334853 [details] [diff] [review]
The little patch

Please use a C++-style reinterpret_cast.  With that, looks ok.
Attachment #334853 - Flags: review?(bzbarsky) → review+
Attached patch The new patch using cast (obsolete) — — Splinter Review 

        Attachment #334853 -
        Attachment is obsolete: true

        Attachment #334989 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 334989 [details] [diff] [review]
The new patch using cast

Please respect the 80-column limit.  Other than that, looks great.

        Attachment #334989 -
        Flags: review?(bzbarsky) → review+

    
    

    
  


  
How about this way?

        Attachment #334989 -
        Attachment is obsolete: true

        Attachment #334992 -
        Flags: review?(bzbarsky)

        Attachment #334992 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
Could you please tell me should I ask for super-review myself? 

    
  

        Attachment #334992 -
        Flags: superreview?(jst)

        Attachment #334992 -
        Flags: superreview?(jst) → superreview+

    
  
Keywords: checkin-needed
Assignee: nobody → Techrazy.Yang

    
    

    
  
Pushed to mozilla-central, changeset 5b0ce4d588e5.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

        Attachment #334992 -
        Attachment description: Third one → Third one
[Checkin: Comment 6]
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1b1
No longer blocks: 449557
Flags: in-testsuite-
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: