Closed Bug 451536 Opened 13 years ago Closed 13 years ago

JSSh port cannot be changed

Categories

(Core Graveyard :: Cmd-line Features, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: ondrej, Assigned: ondrej)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: tip

There is no way how to change the JSSh port from command line. JSSh starts only on port 9997.
A possibility to specify a port number, e.g. with a new -jssh-port <port> option, would help to start JSSh on a different port (if not available) or to start more firefox instances.

Reproducible: Always

Steps to Reproduce:
1. firefox -jssh
Actual Results:  
JSSh started on port 9997.

Expected Results:  
i) with the port number option (-jssh-port <port>)

firefox -jssh -jssh-port 9998
JSSh started on port 9998

ii) without the port number option. It starts on the default port 9997; so it is also backward compatible.

firefox -jssh
JSSh started on port 9997
Attached patch new -jssh-port <port> option (obsolete) — Splinter Review
path:
mozilla-central/extensions/jssh

(sorry, the patch does not contain the whole path; just one file - nsJSShStarter.js - was changed there)
See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree
Assignee: nobody → ondrej
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #334862 - Flags: review?(mano)
Attachment #334862 - Flags: review?(mano) → review?(alex)
Attachment #334862 - Flags: review?(alex) → review+
Comment on attachment 334862 [details] [diff] [review]
new -jssh-port <port> option


>   helpInfo : "  -jssh                Start a JSSh server on port 9997.\n",
>+  helpInfo : "  -jssh-port <port>    Change the JSSh sever port.\n",

You can't have two members of the same name in one object. What you want is something like:

    helpInfo : "  -jssh                Start a JSSh server on port 9997.\n" +
               "  -jssh-port <port>    Change the JSSh server port.\n"

Also note that you misspelled "server".

With those two things fixed, r=me.
thank you alex.
i fixed the two problems (two members in one object and a typo).
Attachment #334862 - Attachment is obsolete: true
Attachment #347104 - Flags: review+
Keywords: checkin-needed
(In reply to comment #1)
> (sorry, the patch does not contain the whole path

(In reply to comment #2)
> See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

See
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_diff_and_patch_files.3F
Version: unspecified → Trunk
Sorry about the delay.

http://hg.mozilla.org/mozilla-central/rev/3274ee5073d9
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.