Link annotations to file diff instead of parent's annotate

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: djc, Assigned: djc)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 334869 [details] [diff] [review]
hg export for the revision that fixes this

People are complaining that the annotate per-line links link to the annotation of the parent revision, whereas it maybe more useful when pointing to the file diff for that parent revision (like it was in bonsai).

I have a patch at http://hg.xavamedia.nl/mozilla/moz-templates/rev/34689b5aab83, which chould be pulled into the canonical mozilla repo and then deployed (also attaching it for review).

(This would include a simple email obfuscation patch for the pushlog, which I could remove again if deemed unwanted.)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

10 years ago
Comment on attachment 334869 [details] [diff] [review]
hg export for the revision that fixes this

Ted, can you review this?
Attachment #334869 - Flags: review?(ted.mielczarek)
Comment on attachment 334869 [details] [diff] [review]
hg export for the revision that fixes this

wfm
Attachment #334869 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

10 years ago
Aravind, can you get this deployed? (Updated templates.)
Usually we file a new bug in mozilla.org : server operations on deployment. You can CC aravind.
Ted: Can you merge this into hg_templates?
Assignee: dirkjan → aravind
Status: ASSIGNED → NEW
Component: Hg: Customizations → Server Operations
Let's keep this bug separate and have ted/djc file a new server-ops bug when they are ready to get this deployed. Otherwise, it makes it difficult to find the bugs where these changes come from.
Assignee: aravind → dirkjan
Component: Server Operations → Hg: Customizations
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 7

10 years ago
reed: sorry, was already told by ted/bsmedberg to file a separate bug. Will do that later, some more stuff is waiting for review.
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Depends on: 453606
(Assignee)

Comment 8

10 years ago
This has been deployed.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.