Closed
Bug 451554
Opened 16 years ago
Closed 16 years ago
C++ inline comments have crept into SeaMonkeys prefwindow.xml
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philip.chee, Assigned: philip.chee)
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
C++ inline comments have crept into the SeaMonkey extended prefwindow.xml via Bug 423486. See: <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/suite/common/bindings/prefwindow.xml&rev=1.12&mark=426,427,449,450> These should be converted to XML comments e.g. <!-- foo --> otherwise they tend to cause unnecessary text nodes to appear in the DOM.
|
Assignee | |
Comment 1•16 years ago
|
||
Fixes comment nit.
Attachment #334894 -
Flags: superreview?(mnyromyr)
Attachment #334894 -
Flags: review?(mnyromyr)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 334894 [details] [diff] [review] Use XML comments instead of C++ inline comments Landed on trunk.
Attachment #334894 -
Flags: superreview?(mnyromyr)
Attachment #334894 -
Flags: review?(mnyromyr)
Attachment #334894 -
Flags: review+
|
|
||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 3•16 years ago
|
||
Actually I think that's one of the places where xbl will ignore text nodes (but of course that's no excuse and they should be comments.)
You need to log in
before you can comment on or make changes to this bug.
Description
•