Last Comment Bug 451591 - Suggested tree cleanup for gfx/
: Suggested tree cleanup for gfx/
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
-- normal with 1 vote (vote)
: mozilla2.0
Assigned To: Nobody; OK to take it and work on it
: Milan Sreckovic [:milan]
Depends on:
Blocks: 430829
  Show dependency treegraph
Reported: 2008-08-21 11:27 PDT by Zack Weinberg (:zwol)
Modified: 2011-10-07 07:19 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Zack Weinberg (:zwol) 2008-08-21 11:27:45 PDT
gfx/ has some unnecessary depth.  The src/shared and src/thebes directories could be brought down to src/ now that thebes is the only rendering implementation in the tree.  Also, per discussion at the summit, public/ and src/ directories are to be collapsed into the parent.  As there are only a handful of files in gfx/idl I think it simpler to bring them up too.  Thus, the proposed renames are:

cd gfx
hg mv src/psshared postscript
hg mv postscript/psshared.pkg postscript/postscript.pkg
hg mv public/*.h .
hg mv idl/*.idl idl/*.pl .
hg mv src/*.{h,cpp,pkg} .
hg mv src/shared/*.{h,cpp} .
hg mv src/thebes/*.{h,cpp} .
hg mv src/thebes/crashtests .
hg rm {idl,public,src/shared,src/thebes,src}/
hg rm idl public src/shared src/thebes src

One must then also merge the deleted Makefiles into the top-level Makefile, which I leave to someone who understands them better and can test cross-platform.
Comment 1 User image Alfred Kayser 2008-08-21 11:46:31 PDT
Move everything to resp. public and src (as is practice in other areas).
But overall I am in favor of this!
Comment 2 User image Zack Weinberg (:zwol) 2008-08-21 11:59:30 PDT
Consensus at the summit was to get rid of public and src everywhere, if I remember correctly.
Comment 3 User image Alfred Kayser 2008-08-22 00:07:42 PDT
Even better. Unfortunately I couldn't make it to the summit :-(
Comment 4 User image Zack Weinberg (:zwol) 2009-01-22 15:53:53 PST
grr, bogus product move.
Comment 5 User image JP Rosevear [:jpr] 2011-10-07 07:19:52 PDT
gfx is currently:
angle  cairo  harfbuzz  ipc  layers  ots  qcms  src  tests  thebes  ycbcr

angle, cairo, harfbuxx, qcms, OTS, ycbcr are all library imports.  src has no subdirectories.  thebes is at the top level as suggested.  Tests are unified in gfx/tests.

I will call this done.

Note You need to log in before you can comment on or make changes to this bug.