451604 - Clicking preview in ctrl-tab panel doesn't work on OS X

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080821020645 Minefield/3.1a2pre ID:20080821020645

With the implementation on bug 445497 it is possible to click on previews now. But that doesn't work on OS X because Ctrl+Click is used as a replacement for the secondary mouse button (e.g. when using Apples one button mouse) to open the context menu. If we want this behavior on OS X too should we also listen on that event? Or is there a better way, Josh?

Comment 1

[Markus Stange [:mstange]]

Dão, would onmouseup instead of onclick work here?

Comment 2

[Dão Gottwald [:dao]]

Probably yes, I need to test it.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347263 [details] [diff] [review]
patch

a=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c178fed8c09c

Comment 7

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre as well as the equivalent build on Tiger.

Comment 8

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7416 added to Litmus.