451647 - Reduce side effects of isDefaultClient/shouldCheckDefaultClient in shell service code

Status: NEW

(SeaMonkey :: OS Integration, defect)

Description

[Frank Wein [:mcsmurf]]

Currently when isDefaultClient (interface nsIShellService) is called with the first parameter being true, it changes the return value of shouldCheckDefaultClient. This can be problematic as shouldCheckDefaultClient is often used together with isDefaultClient in if statements and so the order of those two commands will determinate whether the if statement is true or false.
Possible way to fix this is that calling GetShouldCheckDefaultClient will change mCheckedThisSessionClient to true and isDefaultClient would no longer change mCheckedThisSessionClient and the first parameter could then be removed.