Closed Bug 451668 Opened 12 years ago Closed 12 years ago

Sidebars stay in view when panning URLBar away

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
Windows 2000
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Assuem the web content is panned to the top and the URLBar is showing. If the user has any sidebars (tabs, controls or other) open and starts panning the URLBar away, the sidebars stay in view.

The chrome should probably revert to URLBar only (PANELMODE_URLVIEW) when the URLBar panning starts.
Attachment #334997 - Flags: review?(gavin.sharp)
Comment on attachment 334997 [details] [diff] [review]
Sets the chrome into a safe sate for panning

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+        if (this.mode !== PANELMODE_URLVIEW)
>+          this.show(PANELMODE_URLVIEW);

That extra "=" is unnecessary, right?
Attachment #334997 - Flags: review?(gavin.sharp) → review+
(In reply to comment #1)
> >+        if (this.mode !== PANELMODE_URLVIEW)
> >+          this.show(PANELMODE_URLVIEW);
> 
> That extra "=" is unnecessary, right?
> 

Yeah, it's unnecessary (a typo actually)

changeset:   113:57774a3660f0
tag:         tip
user:        Mark Finkle <mfinkle@mozilla.com>
date:        Fri Aug 22 23:20:46 2008 -0400
summary:     b=451668, r=gavin. Sidebars stay in view when panning URLBar away
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified in beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.