Closed Bug 451672 Opened 11 years ago Closed 11 years ago

nsIMemory::IsLowMemory needs to reflect reality on maemo

Categories

(Core :: XPCOM, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: pavlov, Assigned: dougt)

References

Details

(Keywords: memory-footprint, mobile)

Attachments

(1 file)

This function currently always returns FALSE on linux, which is bad.

For maemo, it needs to always reflect the current reality, so if we're low on memory and have code deleting things in a loop it should eventually return FALSE without having to go back to the main event loop.  Perhaps the maemo callbacks need to be listening on their own thread so they can set this value as it changes?
Flags: blocking1.9.1?
Assignee: dougt → doug.turner
This returns the correct predicate for maemo.  It does not turn on the thread watcher -- that is something we should investigate next (right now we already do get notified via the dbus stuff in toolkit, and it isn't clear that we need yet another way to find out about OOM.  In either case, this patch is required).

Stuart could you review please?
Attachment #335125 - Flags: review?(pavlov)
Comment on attachment 335125 [details] [diff] [review]
patch v.1
[Checkin: Comment 3]

yea, we should get this in.  a little concerned about the performance impact around what this code does, but we can profile it later.
Attachment #335125 - Flags: review?(pavlov) → review+
Mon Aug 25 12:02:13 2008 -0700	82adea5709e8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
removing requestion flag.  stuart -- this patch landed before 1.9.1, so this fix is on the 1.9.1 branch.
Flags: blocking1.9.1?
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.1b1
Version: unspecified → Trunk
Attachment #335125 - Attachment description: patch v.1 → patch v.1 [Checkin: Comment 3]
Depends on: 482008
You need to log in before you can comment on or make changes to this bug.