451686 - OS/2 build break in js/src

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Peter Weilbacher]

We see lots of warnings and error when trying to compile JS now on OS/2 (with GCC 3.3.5, which is the newest that we have):

[... snip ...]
jsapi.cpp
In file included from X:/central/comm/mozilla/js/src/jsregexp.h:47,
                 from X:/central/comm/mozilla/js/src/jscntxt.h:57,
                 from X:/central/comm/mozilla/js/src/jsapi.cpp:59:
X:/central/comm/mozilla/js/src/jsstr.h:244: warning: `fastcall' attribute directive ignored
X:/central/comm/mozilla/js/src/jsstr.h:511: warning: `fastcall' attribute directive ignored
X:/central/comm/mozilla/js/src/jsstr.h:519: warning: `fastcall' attribute directive ignored
In file included from X:/central/comm/mozilla/js/src/jsapi.cpp:59:
X:/central/comm/mozilla/js/src/jscntxt.h:102: error: parse error before `<' token
X:/central/comm/mozilla/js/src/jscntxt.h:103: error: syntax error before `;' token
X:/central/comm/mozilla/js/src/jscntxt.h:132: error: syntax error before `*' token
X:/central/comm/mozilla/js/src/jscntxt.h:184: error: non-template used as template
X:/central/comm/mozilla/js/src/jscntxt.h:187: error: non-template used as template
[... snip ...]

The critical one seems to be the line
   extern "C++" template<typename T> class Queue;
in
   http://mxr.mozilla.org/mozilla-central/source/js/src/jscntxt.h#102

Comment 1

[Peter Weilbacher]

Attachment: fix

This fixes it for me. (Not asking for review yet, I want to see the tree opened again in case there are more changes to this code for other platforms, too.)

Comment 2

[Peter Weilbacher]

Comment on attachment 335021 [details] [diff] [review]
fix

OK, the tree is still closed but the other platforms seem to be happy, so I can as well ask for review now to check it in after reopening.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 335021 [details] [diff] [review]
fix

r=shaver

Comment 4

[Peter Weilbacher]

Pushed to mozilla-central, changeset - 18497:ccf551580fc7.