remove unneeded global variables

RESOLVED FIXED in Firefox 3.1b1

Status

()

--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: zeniko, Assigned: zeniko)

Tracking

Trunk
Firefox 3.1b1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
... such as _dirty (can be replaced by a function argument) or _lastSessionCrashed (used inside one function only).
(Assignee)

Comment 1

10 years ago
Created attachment 335039 [details] [diff] [review]
code shuffling

This also takes into account bug 36810 comment #174, clearing up some code flow issues in the init functions of both nsSessionStore and nsSessionStartup.
Attachment #335039 - Flags: review?(dietrich)
Comment on attachment 335039 [details] [diff] [review]
code shuffling


>@@ -190,50 +187,49 @@ SessionStoreService.prototype = {
> 
>     // get file references
>     var dirService = Cc["@mozilla.org/file/directory_service;1"].
>                      getService(Ci.nsIProperties);
>     this._sessionFile = dirService.get("ProfD", Ci.nsILocalFile);
>     this._sessionFileBackup = this._sessionFile.clone();
>     this._sessionFile.append("sessionstore.js");
>     this._sessionFileBackup.append("sessionstore.bak");
>-   
>+    

added a new unnecessary space

looks ok otherwise, r=me
Attachment #335039 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

10 years ago
Created attachment 337050 [details] [diff] [review]
unbitrotted for check-in
[Checkin: Comment 4]
Assignee: nobody → zeniko
Attachment #335039 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 337050 [details] [diff] [review]
unbitrotted for check-in
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/071e187e2b8e
Attachment #337050 - Attachment description: unbitrotted for check-in → unbitrotted for check-in [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.