Closed Bug 451702 Opened 14 years ago Closed 14 years ago

remove unneeded global variables

Categories

(Firefox :: Session Restore, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3.1b1

People

(Reporter: zeniko, Assigned: zeniko)

Details

Attachments

(1 file, 1 obsolete file)

... such as _dirty (can be replaced by a function argument) or _lastSessionCrashed (used inside one function only).
Attached patch code shuffling (obsolete) — Splinter Review
This also takes into account bug 36810 comment #174, clearing up some code flow issues in the init functions of both nsSessionStore and nsSessionStartup.
Attachment #335039 - Flags: review?(dietrich)
Comment on attachment 335039 [details] [diff] [review]
code shuffling


>@@ -190,50 +187,49 @@ SessionStoreService.prototype = {
> 
>     // get file references
>     var dirService = Cc["@mozilla.org/file/directory_service;1"].
>                      getService(Ci.nsIProperties);
>     this._sessionFile = dirService.get("ProfD", Ci.nsILocalFile);
>     this._sessionFileBackup = this._sessionFile.clone();
>     this._sessionFile.append("sessionstore.js");
>     this._sessionFileBackup.append("sessionstore.bak");
>-   
>+    

added a new unnecessary space

looks ok otherwise, r=me
Attachment #335039 - Flags: review?(dietrich) → review+
Assignee: nobody → zeniko
Attachment #335039 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 337050 [details] [diff] [review]
unbitrotted for check-in
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/071e187e2b8e
Attachment #337050 - Attachment description: unbitrotted for check-in → unbitrotted for check-in [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.