Open Bug 451844 Opened 13 years ago Updated 9 years ago
Kill non-MDB uses of ns
Sorry about that, bugzilla let me commit an empty bug. http://mxr.mozilla.org/comm-central/search?string=nsIAddrDatabase&find=mailnews That finds 123 matches in 48 files, most of which are outside the valid use files (MDB directory stuff). Major areas to kill: * Compose and address collector use it for "CardForProperty" * LDAP replication uses it * Palmsync uses it * And, most notably, import uses it.
This kills it in the casual uses, i.e., point 1 of my previous comment.
(In reply to comment #1) > Major areas to kill: > * Compose and address collector use it for "CardForProperty" > * LDAP replication uses it > * Palmsync uses it > * And, most notably, import uses it. We need to have a think about LDAP replication. Personally I'd rather it used something like nsIAddrDatabase rather than nsIAbMDBDirectory. The reason being is that currently LDAP replication gets the database via a "hacked" nsIAbMDBDirectory that we can only get in that state because of rdf allowing it. (In reply to comment #2) > Created an attachment (id=335174) [details] > A start on "casual" uses > > This kills it in the casual uses, i.e., point 1 of my previous comment. ... + abDirectory->ModifyCard(existingCard); You need to check the directory is writeable before getting this far. There's no point in finding the card etc if its not writeable.
You need to log in before you can comment on or make changes to this bug.