451988 - Move MailNewsTypes* from mailnews to msgbase

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Ian Neal]

When we depend on msgbase we always seem to depend on mailnews too. It does seem to not make much sense with their current setup and just forces us to depend on yet another directory.
The suggestion from Neil is to move MailNewsTypes* from mailnews to msgbase.

Comment 1

[Ian Neal]

Attachment: mailnews into msgbase patch v0.1

This patch:
* Moves MailNewsTypes* into msgbase (mailnews/base/public) from mailnews (mailnews/public)
* Removes the now redundant mailnews dependencies in all the Makefile.in files

Comment 2

[[e-mail]]

Comment on attachment 335310 [details] [diff] [review]
mailnews into msgbase patch v0.1

> EXPORTS		= \
> 		msgCore.h \
> 		nsMsgBaseCID.h \
> 		nsMsgHeaderMasks.h \
> 		nsMsgMessageFlags.h \
> 		nsMsgLocalFolderHdrs.h \
>+		MailNewsTypes.h \
> 		$(NULL)
I'd have put this first in the list (and the same for MailNewsTypes2.idl).

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 335310 [details] [diff] [review]
mailnews into msgbase patch v0.1

 EXPORTS		= \
 		msgCore.h \
 		nsMsgBaseCID.h \
 		nsMsgHeaderMasks.h \
 		nsMsgMessageFlags.h \
 		nsMsgLocalFolderHdrs.h \
+		MailNewsTypes.h \
 		$(NULL)
 

Have you tried the patch without this change?

If so, what fails?

Comment 4

[Ian Neal]

(In reply to comment #3)
> (From update of attachment 335310 [details] [diff] [review])
>  EXPORTS                = \
>                 msgCore.h \
>                 nsMsgBaseCID.h \
>                 nsMsgHeaderMasks.h \
>                 nsMsgMessageFlags.h \
>                 nsMsgLocalFolderHdrs.h \
> +               MailNewsTypes.h \
>                 $(NULL)
> 
> 
> Have you tried the patch without this change?
> 
> If so, what fails?
> 
In file included from /mozdev/src/mailnews/base/src/nsMessenger.cpp:104:
../../../mozilla/dist/include/msgbase/nsIMsgMessageService.h:35:27: error: MailNewsTypes.h: No such file or directory
/mozdev/src/mailnews/base/src/nsMessenger.cpp: In member function ‘virtual nsresult nsSaveMsgListener::OnStopRunningUrl(nsIURI*, nsresult)’:
/mozdev/src/mailnews/base/src/nsMessenger.cpp:1637: error: ‘MSG_FLAG_READ’ was not declared in this scope

Comment 5

[Ian Neal]

Attachment: mailnews into msgbase patch v0.1a (Checkin: Comment 6)

Changes since v0.1:
* Reordered where MailNewsTypes* went in msgbase's Makefile.in as per Neil's comment
* Added removal of mailnews \ from mime/build/Makefile.in introduced by patch from bug 451903

Carrying forward sr=

Comment 6

[Ian Neal]

Comment on attachment 335425 [details] [diff] [review]
mailnews into msgbase patch v0.1a (Checkin: Comment 6)

pushing to ssh://[e-mail]@hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 41 changes to 41 files
http://hg.mozilla.org/comm-central/index.cgi/rev/4b62be6f26a1