Closed Bug 451988 Opened 11 years ago Closed 11 years ago

Move MailNewsTypes* from mailnews to msgbase

Categories

(MailNews Core :: Backend, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a2

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

When we depend on msgbase we always seem to depend on mailnews too. It does seem to not make much sense with their current setup and just forces us to depend on yet another directory.
The suggestion from Neil is to move MailNewsTypes* from mailnews to msgbase.
Blocks: 451903
Attached patch mailnews into msgbase patch v0.1 (obsolete) — Splinter Review
This patch:
* Moves MailNewsTypes* into msgbase (mailnews/base/public) from mailnews (mailnews/public)
* Removes the now redundant mailnews dependencies in all the Makefile.in files
Attachment #335310 - Flags: superreview?(neil)
Attachment #335310 - Flags: review?(bugzilla)
Comment on attachment 335310 [details] [diff] [review]
mailnews into msgbase patch v0.1

> EXPORTS		= \
> 		msgCore.h \
> 		nsMsgBaseCID.h \
> 		nsMsgHeaderMasks.h \
> 		nsMsgMessageFlags.h \
> 		nsMsgLocalFolderHdrs.h \
>+		MailNewsTypes.h \
> 		$(NULL)
I'd have put this first in the list (and the same for MailNewsTypes2.idl).
Attachment #335310 - Flags: superreview?(neil) → superreview+
Comment on attachment 335310 [details] [diff] [review]
mailnews into msgbase patch v0.1

 EXPORTS		= \
 		msgCore.h \
 		nsMsgBaseCID.h \
 		nsMsgHeaderMasks.h \
 		nsMsgMessageFlags.h \
 		nsMsgLocalFolderHdrs.h \
+		MailNewsTypes.h \
 		$(NULL)
 

Have you tried the patch without this change?

If so, what fails?
(In reply to comment #3)
> (From update of attachment 335310 [details] [diff] [review])
>  EXPORTS                = \
>                 msgCore.h \
>                 nsMsgBaseCID.h \
>                 nsMsgHeaderMasks.h \
>                 nsMsgMessageFlags.h \
>                 nsMsgLocalFolderHdrs.h \
> +               MailNewsTypes.h \
>                 $(NULL)
> 
> 
> Have you tried the patch without this change?
> 
> If so, what fails?
> 
In file included from /mozdev/src/mailnews/base/src/nsMessenger.cpp:104:
../../../mozilla/dist/include/msgbase/nsIMsgMessageService.h:35:27: error: MailNewsTypes.h: No such file or directory
/mozdev/src/mailnews/base/src/nsMessenger.cpp: In member function ‘virtual nsresult nsSaveMsgListener::OnStopRunningUrl(nsIURI*, nsresult)’:
/mozdev/src/mailnews/base/src/nsMessenger.cpp:1637: error: ‘MSG_FLAG_READ’ was not declared in this scope

No longer blocks: 451903
Attachment #335310 - Flags: review?(bugzilla)
Changes since v0.1:
* Reordered where MailNewsTypes* went in msgbase's Makefile.in as per Neil's comment
* Added removal of mailnews \ from mime/build/Makefile.in introduced by patch from bug 451903

Carrying forward sr=
Attachment #335310 - Attachment is obsolete: true
Attachment #335425 - Flags: superreview+
Attachment #335425 - Flags: review?(bugzilla)
Attachment #335425 - Flags: review?(bugzilla) → review+
Comment on attachment 335425 [details] [diff] [review]
mailnews into msgbase patch v0.1a (Checkin: Comment 6)

pushing to ssh://iann_cvs@blueyonder.co.uk@hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 41 changes to 41 files
http://hg.mozilla.org/comm-central/index.cgi/rev/4b62be6f26a1
Attachment #335425 - Attachment description: mailnews into msgbase patch v0.1a → mailnews into msgbase patch v0.1a (Checkin: Comment 6)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in before you can comment on or make changes to this bug.