Closed Bug 452014 Opened 16 years ago Closed 16 years ago

cleanup of nsMailboxProtocol::LoadUrl

Categories

(Thunderbird :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0a3

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080702 Ubuntu/8.04 (hardy) Firefox/2.0.0.15 Kazehakase/0.5.4
Build Identifier: 

In nsMailboxProtocol::LoadUrl,

switch (m_mailboxAction)
{
case nsIMailboxUrl::ActionSaveMessageToDisk:
 ..
 // fall through
case nsIMailboxUrl::ActionCopyMessage:
case nsIMailboxUrl::ActionMoveMessage:
case nsIMailboxUrl::ActionFetchMessage:
  if (m_mailboxAction == nsIMailboxUrl::ActionSaveMessageToDisk)
  { 
   ...

The if statement is redundant, the process should be included in the previous case statement.




Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch Cleanup (obsolete) — Splinter Review
Attachment #335309 - Flags: superreview?(bienvenu)
Attachment #335309 - Flags: review?(bienvenu)
Severity: normal → minor
Comment on attachment 335309 [details] [diff] [review]
Cleanup

thx for the patch, looks good, except that it looks like you put in a tab here, instead of spaces:

-            nsCOMPtr<nsIMsgMessageUrl> messageUrl = do_QueryInterface(aURL, &rv);
+					{
+            nsCOMPtr<nsIMsgMessageUrl> messageUrl = do_QueryInterface(m_runningUrl, &rv);
Attachment #335309 - Flags: superreview?(bienvenu)
Attachment #335309 - Flags: superreview+
Attachment #335309 - Flags: review?(bienvenu)
Attachment #335309 - Flags: review+
Attached patch Remove tabsSplinter Review
I am sorry my carelessness.
Attachment #335309 - Attachment is obsolete: true
Attachment #335441 - Flags: superreview?(bienvenu)
Attachment #335441 - Flags: review+
Comment on attachment 335441 [details] [diff] [review]
Remove tabs

no problem, thanks for the patch!
Attachment #335441 - Flags: superreview?(bienvenu) → superreview+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
Checked in, changeset id: 194:67fbeb41e45c
Assignee: nobody → poincare
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 3.0b1
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: