Closed
Bug 452014
Opened 16 years ago
Closed 16 years ago
cleanup of nsMailboxProtocol::LoadUrl
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file, 1 obsolete file)
2.54 KB,
patch
|
hiro
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080702 Ubuntu/8.04 (hardy) Firefox/2.0.0.15 Kazehakase/0.5.4 Build Identifier: In nsMailboxProtocol::LoadUrl, switch (m_mailboxAction) { case nsIMailboxUrl::ActionSaveMessageToDisk: .. // fall through case nsIMailboxUrl::ActionCopyMessage: case nsIMailboxUrl::ActionMoveMessage: case nsIMailboxUrl::ActionFetchMessage: if (m_mailboxAction == nsIMailboxUrl::ActionSaveMessageToDisk) { ... The if statement is redundant, the process should be included in the previous case statement. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #335309 -
Flags: superreview?(bienvenu)
Attachment #335309 -
Flags: review?(bienvenu)
Assignee | ||
Updated•16 years ago
|
Severity: normal → minor
Comment 2•16 years ago
|
||
Comment on attachment 335309 [details] [diff] [review] Cleanup thx for the patch, looks good, except that it looks like you put in a tab here, instead of spaces: - nsCOMPtr<nsIMsgMessageUrl> messageUrl = do_QueryInterface(aURL, &rv); + { + nsCOMPtr<nsIMsgMessageUrl> messageUrl = do_QueryInterface(m_runningUrl, &rv);
Attachment #335309 -
Flags: superreview?(bienvenu)
Attachment #335309 -
Flags: superreview+
Attachment #335309 -
Flags: review?(bienvenu)
Attachment #335309 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
I am sorry my carelessness.
Attachment #335309 -
Attachment is obsolete: true
Attachment #335441 -
Flags: superreview?(bienvenu)
Attachment #335441 -
Flags: review+
Comment 4•16 years ago
|
||
Comment on attachment 335441 [details] [diff] [review] Remove tabs no problem, thanks for the patch!
Attachment #335441 -
Flags: superreview?(bienvenu) → superreview+
Updated•16 years ago
|
Comment 5•16 years ago
|
||
Checked in, changeset id: 194:67fbeb41e45c
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•