452056 - browser hangs up forever on restart if seperator in bookmak manager contains double quote characters

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[kai ng]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11

I am in Bookmark manager. If I use the double quote character in the rename a of
Seperator, the program crashes when I run the Seamonkey browser.

Reproducible: Always

Steps to Reproduce:
1.Open bookmark manager
2.Click new seperator
3.Click rename to add text to the seperator line.
4.Do it with the Rename text containing ""
5.Close SeaMonkey
Actual Results:  
1.Start SeaMonkey browser again. Program hangs forever

Expected Results:  
Progarm to run properly

Properly encode or drop the quote character (or any other character which may affect the HTML interpreter).

Comment 1

[lenochod]

Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.0.1pre) Gecko/2008062408 SeaMonkey/2.0a1pre
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11

Hangs confirming, on trunk and 1.1.11 versions.

Firefox does not contain rename.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Escaped the keyword too, just in case.

Comment 3

[Ian Neal]

Comment on attachment 399183 [details] [diff] [review]
Proposed patch

>--- a/suite/browser/src/nsBookmarksService.cpp	Mon Sep 07 14:27:14 2009 -0700
>+                if (property == kNC_Name || property == kNC_ShortcutURL)
>+                {
>+                    EscapeHTML(attribute);
>+                }
Do we need the braces?

Comment 4

[[e-mail]]

Pushed changeset 79163e3ee03f to comm-central.