452072 - revised bookmarks list UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect, P2)

Description

[Madhava Enros [:madhava]]

Finish the revised (simplified) bookmarks list UI, so that it can be built.  For some context, it's mostly like what exists right now in Fennec M7, except without the location bar at the top of the screen.

Comment 1

[Stuart Parmenter]

madhava, can you work with neil on this?

Comment 2

[Madhava Enros [:madhava]]

Attachment: bookmarks screen

This is basically what I'm thinking -- the vertically pannable bookmarks list takes up the whole screen.  There's still some more thinking required about how it's going to be dismissed, exactly.  There's a (x) button shown at the bottom of this panel, but it may be preferable to have some of the content shown and be tappable to dismiss the panel - more on this later.  For the moment, though, this should be workable.

Comment 3

[Neil Deakin]

Attachment: minor bookmarks changes

- bookmarks take up the entire screen
- add a close button
- support key navigation as well

Comment 4

[Neil Deakin]

It would make more sense to me though to just show the bookmarks in the content area as currently, and use the bookmarks open button to close it -- it could change to an X.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 337489 [details] [diff] [review]
minor bookmarks changes

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+    if (aMode != PANELMODE_BOOKMARKLIST)
>+        toolbar.hidden = false;
>+

Do you need this? Don't all the other modes already call this._showToolbar ?

>     }
>     else if (aMode == PANELMODE_BOOKMARKLIST) {
>       this._showToolbar();
>       toolbar.setAttribute("mode", "view");
>+      toolbar.hidden = true;

You should just change the this._showToolbar to this._hideToolbar

Comment 6

[Neil Deakin]

Attachment: updated patch and add support for pressing escape to close bookmarks list

Comment 7

[Neil Deakin]

Checked in

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

we have revamped this for beta2 release.